mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Heyi Guo <guoheyi@huawei.com>, Heyi Guo <heyi.guo@linaro.org>,
	Lubomir Rintel <lkundrak@v3.sk>, Pavel Machek <pavel@ucw.cz>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Zheng Xiang <zhengxiang9@huawei.com>,
	Jason Cooper <jason@lakedaemon.net>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable
Date: Wed,  6 Feb 2019 10:48:47 +0000	[thread overview]
Message-ID: <20190206104848.12580-5-marc.zyngier@arm.com> (raw)
In-Reply-To: <20190206104848.12580-1-marc.zyngier@arm.com>

From: Lubomir Rintel <lkundrak@v3.sk>

Resetting bit 4 disables the interrupt delivery to the "secure
processor" core. This breaks the keyboard on a OLPC XO 1.75 laptop,
where the firmware running on the "secure processor" bit-bangs the
PS/2 protocol over the GPIO lines.

It is not clear what the rest of the bits are and Marvell was unhelpful
when asked for documentation. Aside from the SP bit, there are probably
priority bits.

Leaving the unknown bits as the firmware set them up seems to be a wiser
course of action compared to just turning them off.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
[maz: fixed-up subject and commit message]
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 drivers/irqchip/irq-mmp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mmp.c b/drivers/irqchip/irq-mmp.c
index 25f32e1d7764..3496b61a312a 100644
--- a/drivers/irqchip/irq-mmp.c
+++ b/drivers/irqchip/irq-mmp.c
@@ -34,6 +34,9 @@
 #define SEL_INT_PENDING		(1 << 6)
 #define SEL_INT_NUM_MASK	0x3f
 
+#define MMP2_ICU_INT_ROUTE_PJ4_IRQ	(1 << 5)
+#define MMP2_ICU_INT_ROUTE_PJ4_FIQ	(1 << 6)
+
 struct icu_chip_data {
 	int			nr_irqs;
 	unsigned int		virq_base;
@@ -190,7 +193,8 @@ static const struct mmp_intc_conf mmp_conf = {
 static const struct mmp_intc_conf mmp2_conf = {
 	.conf_enable	= 0x20,
 	.conf_disable	= 0x0,
-	.conf_mask	= 0x7f,
+	.conf_mask	= MMP2_ICU_INT_ROUTE_PJ4_IRQ |
+			  MMP2_ICU_INT_ROUTE_PJ4_FIQ,
 };
 
 static void __exception_irq_entry mmp_handle_irq(struct pt_regs *regs)
-- 
2.20.1


  parent reply	other threads:[~2019-02-06 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 10:48 [PATCH 0/5] irqchip updates for 5.0-rc6 Marc Zyngier
2019-02-06 10:48 ` [PATCH 1/5] irqchip/gic-v4: Fix occasional VLPI drop Marc Zyngier
2019-02-06 10:48 ` [PATCH 2/5] irqchip/gic-v3-its: Plug allocation race for devices sharing a DevID Marc Zyngier
2019-02-06 10:48 ` [PATCH 3/5] irqchip/gic-v3-its: Gracefully fail on LPI exhaustion Marc Zyngier
2019-02-06 10:48 ` Marc Zyngier [this message]
2019-02-06 10:48 ` [PATCH 5/5] irqchip/gic-v3-its: Fix ITT_entry_size accessor Marc Zyngier
2019-02-06 10:57 ` [PATCH 0/5] irqchip updates for 5.0-rc6 Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190206104848.12580-5-marc.zyngier@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=guoheyi@huawei.com \
    --cc=heyi.guo@linaro.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=pavel@ucw.cz \
    --cc=tglx@linutronix.de \
    --cc=yuzenghui@huawei.com \
    --cc=zhengxiang9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®