From: David Miller <davem@davemloft.net>
To: eli@mellanox.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
simon.horman@netronome.com, jakub.kicinski@netronome.com,
dirk.vandermerwe@netronome.com, francois.theron@netronome.com,
quentin.monnet@netronome.com, john.hurley@netronome.com,
edwin.peer@netronome.com
Subject: Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE
Date: Thu, 07 Feb 2019 10:01:10 -0800 (PST) [thread overview]
Message-ID: <20190207.100110.1557913033627638063.davem@davemloft.net> (raw)
In-Reply-To: <20190207074549.29861-3-eli@mellanox.com>
From: Eli Cohen <eli@mellanox.com>
Date: Thu, 7 Feb 2019 09:45:49 +0200
> diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
> index 902957beceb3..d54cb608dbaf 100644
> --- a/net/sched/act_simple.c
> +++ b/net/sched/act_simple.c
> @@ -19,8 +19,6 @@
> #include <net/netlink.h>
> #include <net/pkt_sched.h>
>
> -#define TCA_ACT_SIMP 22
> -
> #include <linux/tc_act/tc_defact.h>
> #include <net/tc_act/tc_defact.h>
>
I would do this in patch #1.
Actually, because you didn't, after patch #1 there are two #defines
evaluated for this macro. One in pkt_cls.h and one here.
The only reason the compiler doesn't warn and complain is because the
definitions are identical.
Thank you.
next prev parent reply other threads:[~2019-02-07 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 7:45 [PATCH net-next 0/2] Change tc action identifiers to be more consistent Eli Cohen
2019-02-07 7:45 ` [PATCH net-next 1/2] net: Move all TC actions identifiers to one place Eli Cohen
2019-02-07 7:45 ` [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE Eli Cohen
2019-02-07 18:01 ` David Miller [this message]
2019-02-10 8:19 ` Eli Cohen
2019-02-08 8:01 ` Simon Horman
2019-02-08 8:39 ` Jiri Pirko
2019-02-07 13:00 ` [PATCH net-next 0/2] Change tc action identifiers to be more consistent Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207.100110.1557913033627638063.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=edwin.peer@netronome.com \
--cc=eli@mellanox.com \
--cc=francois.theron@netronome.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®