From: Andre Noll <maan@tuebingen.mpg.de>
To: Coly Li <colyli@suse.de>
Cc: Dave Chinner <david@fromorbit.com>, Nix <nix@esperi.org.uk>,
linux-bcache@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk
Subject: Re: bcache on XFS: metadata I/O (dirent I/O?) not getting cached at all?
Date: Thu, 7 Feb 2019 10:28:19 +0100 [thread overview]
Message-ID: <20190207092819.GY24140@tuebingen.mpg.de> (raw)
In-Reply-To: <b982a23b-7225-d20a-2802-60bce314ccc2@suse.de>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Thu, Feb 07, 10:27, Coly Li wrote
> If different file system handles metadata flags in unified ways, it is
> OK to me to change the code to: !(bio->bi_opf & (REQ_META |REQ_PRIO)).
Yes, that's the smallest fix that should also go into 4.19-stable.
In the long run, we should try to get rid of the 45 instances of
REQ_PRIO. Most users specify REQ_META | REQ_PRIO anyway, which leaves
only a few other instances to look at.
I think the one in submit_bh_wbc() of fs/buffer.c can just be removed
while block/cfq-iosched.c does not use REQ_META at all, so the simple
s/REQ_PRIO/REQ_META should be OK. drivers/staging/erofs/data.c is
also easy to fix.
Best
Andre
--
Max Planck Institute for Developmental Biology
Max-Planck-Ring 5, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-02-07 9:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 22:11 Nix
2019-02-06 23:43 ` Dave Chinner
2019-02-07 0:24 ` Andre Noll
2019-02-07 2:26 ` Dave Chinner
2019-02-07 2:38 ` Coly Li
2019-02-07 3:10 ` Dave Chinner
2019-02-07 8:18 ` Coly Li
2019-02-07 13:10 ` Nix
2019-02-07 2:27 ` Coly Li
2019-02-07 9:28 ` Andre Noll [this message]
2019-02-07 8:16 ` Coly Li
2019-02-07 9:41 ` Andre Noll
2019-02-07 10:23 ` Coly Li
2019-02-07 20:51 ` Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207092819.GY24140@tuebingen.mpg.de \
--to=maan@tuebingen.mpg.de \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®