From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE09C282C2 for ; Thu, 7 Feb 2019 08:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0479A20818 for ; Thu, 7 Feb 2019 08:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbfBGI4x (ORCPT ); Thu, 7 Feb 2019 03:56:53 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:49718 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfBGI4x (ORCPT ); Thu, 7 Feb 2019 03:56:53 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1BB2227DFBF; Thu, 7 Feb 2019 08:56:50 +0000 (GMT) Date: Thu, 7 Feb 2019 09:56:47 +0100 From: Boris Brezillon To: "Sobon, Przemyslaw" Cc: Liu Jian , "ikegami@allied-telesis.co.jp" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "richard@nod.at" , "joakim.tjernlund@infinera.com" , "keescook@chromium.org" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer Message-ID: <20190207095635.0fc3b411@kernel.org> In-Reply-To: References: <1548977439-318904-1-git-send-email-liujian56@huawei.com> <20190203092645.18d1495b@bbrezillon> <20190203093509.269bf1e1@bbrezillon> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sobon, On Tue, 5 Feb 2019 22:28:44 +0000 "Sobon, Przemyslaw" wrote: > > From: Boris Brezillon > > Sent: Sunday, February 3, 2019 12:35 AM > > > +Przemyslaw > > > > > > On Fri, 1 Feb 2019 07:30:39 +0800 > > > Liu Jian wrote: > > > > > > > In function do_write_buffer(), in the for loop, there is a case > > > > chip_ready() returns 1 while chip_good() returns 0, so it never > > > > break the loop. > > > > To fix this, chip_good() is enough and it should timeout if it stay > > > > bad for a while. > > > > > > Looks like Przemyslaw reported and fixed the same problem. > > > > > > > > > > > Fixes: dfeae1073583(mtd: cfi_cmdset_0002: Change write buffer to > > > > check correct value) > > > > > > Can you put the Fixes tag on a single, and the format is > > > > > > Fixes: ("message") > > > > > > > Signed-off-by: Yi Huaijie > > > > Signed-off-by: Liu Jian > > > > > > [1]http://patchwork.ozlabs.org/patch/1025566/ > > > > > > > --- > > > > drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c > > > > b/drivers/mtd/chips/cfi_cmdset_0002.c > > > > index 72428b6..818e94b 100644 > > > > --- a/drivers/mtd/chips/cfi_cmdset_0002.c > > > > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c > > > > @@ -1876,14 +1876,14 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, > > > > continue; > > > > } > > > > > > > > - if (time_after(jiffies, timeo) && !chip_ready(map, adr)) > > > > - break; > > > > - > > > > if (chip_good(map, adr, datum)) { > > > > xip_enable(map, chip, adr); > > > > goto op_done; > > > > } > > > > > > > > + if (time_after(jiffies, timeo)) > > > > + break; > > > > + > > > > /* Latency issues. Drop the lock, wait a while and retry */ > > > > UDELAY(map, chip, adr, 1); > > > > } > > > > > > > BTW, the patch itself looks good to me. Ikegami, can you confirm it does the right thing? > > > > Thanks, > > > > Boris > > > > One comment to this patch. If value is written incorrectly quickly we will be > stuck in the loop even though nothing is going to change. For example a value was > written incorrectly after 1us, the loop was set to 1ms, function will return > after 1ms, this solution is not optimized for performance. I considered same > when working on this change and decided to do it different way. Seems like you're right if we assume that checking for GOOD state does not require a delay after the READY check, but if that's not the case and an extra delay is actually required, you might end up with a BAD status while it could have turned GOOD at some point with the 'check only for GOOD state until we timeout' approach. TBH, I don't know how CFI flashes work, so I'll let you guys sort this out. Regards, Boris