From: Daniel Vetter <daniel@ffwll.ch>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, david.emett@broadcom.com,
thomas.spurden@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/v3d: Fix BO stats accounting for dma-buf-imported buffers.
Date: Fri, 8 Feb 2019 00:27:17 +0100 [thread overview]
Message-ID: <20190207232717.GG23159@phenom.ffwll.local> (raw)
In-Reply-To: <20190207232613.24981-1-eric@anholt.net>
On Thu, Feb 07, 2019 at 03:26:13PM -0800, Eric Anholt wrote:
> We always decrement at GEM free, so make sure we increment at GEM
> creation for dma-bufs.
Indeed. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/gpu/drm/v3d/v3d_bo.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c
> index a08766d39eab..b1766f096c4b 100644
> --- a/drivers/gpu/drm/v3d/v3d_bo.c
> +++ b/drivers/gpu/drm/v3d/v3d_bo.c
> @@ -282,6 +282,7 @@ v3d_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt)
> {
> + struct v3d_dev *v3d = to_v3d_dev(dev);
> struct drm_gem_object *obj;
> struct v3d_bo *bo;
>
> @@ -296,6 +297,11 @@ v3d_prime_import_sg_table(struct drm_device *dev,
> obj->import_attach = attach;
> v3d_bo_get_pages(bo);
>
> + mutex_lock(&v3d->bo_lock);
> + v3d->bo_stats.num_allocated++;
> + v3d->bo_stats.pages_allocated += obj->size >> PAGE_SHIFT;
> + mutex_unlock(&v3d->bo_lock);
> +
> v3d_mmu_insert_ptes(bo);
>
> return obj;
> --
> 2.20.0.rc1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-02-07 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 23:26 Eric Anholt
2019-02-07 23:27 ` Daniel Vetter [this message]
2019-02-12 20:04 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207232717.GG23159@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=david.emett@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.spurden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®