From: kbuild test robot <lkp@intel.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Dave Gerlach <d-gerlach@ti.com>, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 2/2] cpufreq: dt: rework resources initialization
Date: Fri, 8 Feb 2019 09:26:55 +0800 [thread overview]
Message-ID: <201902080937.M1vOJ8vE%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190207122227.19873-3-m.szyprowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 3301 bytes --]
Hi Marek,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pm/linux-next]
[also build test WARNING on next-20190207]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Marek-Szyprowski/cpufreq-opp-rework-regulator-initialization/20190208-071454
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.2.0 make.cross ARCH=sh
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers//cpufreq/cpufreq-dt.c: In function 'dt_cpufreq_probe':
>> drivers//cpufreq/cpufreq-dt.c:149:12: warning: 'cpu_reg' may be used uninitialized in this function [-Wmaybe-uninitialized]
priv->reg = cpu_reg;
~~~~~~~~~~^~~~~~~~~
drivers//cpufreq/cpufreq-dt.c:102:20: note: 'cpu_reg' was declared here
struct regulator *cpu_reg;
^~~~~~~
vim +/cpu_reg +149 drivers//cpufreq/cpufreq-dt.c
98
99 static int get_cpu_resources(struct private_data *priv, unsigned int cpu)
100 {
101 struct device *cpu_dev;
102 struct regulator *cpu_reg;
103 struct clk *cpu_clk;
104 int ret = 0;
105 const char *name;
106
107 cpu_dev = get_cpu_device(cpu);
108 if (!cpu_dev) {
109 pr_err("failed to get cpu%d device\n", cpu);
110 return -ENODEV;
111 }
112
113 cpu_clk = clk_get(cpu_dev, NULL);
114 ret = PTR_ERR_OR_ZERO(cpu_clk);
115 if (ret) {
116 /*
117 * If cpu's clk node is present, but clock is not yet
118 * registered, we should try defering probe.
119 */
120 if (ret == -EPROBE_DEFER)
121 dev_dbg(cpu_dev, "clock not ready, retry\n");
122 else
123 dev_err(cpu_dev, "failed to get clock: %d\n", ret);
124
125 return ret;
126 }
127
128 name = find_supply_name(cpu_dev);
129 /* Platform doesn't require regulator */
130 if (!name)
131 goto no_regulator;
132
133 cpu_reg = regulator_get_optional(cpu_dev, name);
134 ret = PTR_ERR_OR_ZERO(cpu_reg);
135 if (ret) {
136 /*
137 * If cpu's regulator supply node is present, but regulator is
138 * not yet registered, we should try defering probe.
139 */
140 if (ret == -EPROBE_DEFER)
141 dev_dbg(cpu_dev, "regulator not ready, retry\n");
142 else
143 dev_dbg(cpu_dev, "no regulator for cpu: %d\n", ret);
144 goto free;
145 }
146 no_regulator:
147 priv->cpu_dev = cpu_dev;
148 priv->clk = cpu_clk;
> 149 priv->reg = cpu_reg;
150 return 0;
151 free:
152 clk_put(cpu_clk);
153 return ret;
154 }
155
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50796 bytes --]
next prev parent reply other threads:[~2019-02-08 1:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190207122255eucas1p1cdebed838c799eca46cce6a654a26187@eucas1p1.samsung.com>
2019-02-07 12:22 ` [PATCH 0/2] cpufreq/opp: rework regulator initialization Marek Szyprowski
[not found] ` <CGME20190207122255eucas1p1444023f01217a43cfb958fe0bd48ef4d@eucas1p1.samsung.com>
2019-02-07 12:22 ` [PATCH 1/2] cpufreq: dt/ti/opp: move regulators initialization to the drivers Marek Szyprowski
[not found] ` <CGME20190207122256eucas1p17e8742176bda911263d2d14d2797a886@eucas1p1.samsung.com>
2019-02-07 12:22 ` [PATCH 2/2] cpufreq: dt: rework resources initialization Marek Szyprowski
2019-02-08 1:26 ` kbuild test robot [this message]
2019-02-08 6:49 ` [PATCH 0/2] cpufreq/opp: rework regulator initialization Viresh Kumar
2019-02-08 8:12 ` Marek Szyprowski
2019-02-08 8:55 ` Viresh Kumar
2019-02-08 9:15 ` Marek Szyprowski
2019-02-08 9:23 ` Viresh Kumar
2019-02-08 10:02 ` Marek Szyprowski
2019-02-08 10:08 ` Rafael J. Wysocki
2019-02-08 10:18 ` Rafael J. Wysocki
2019-02-08 10:28 ` Viresh Kumar
2019-02-08 10:22 ` Rafael J. Wysocki
2019-02-08 10:31 ` Marek Szyprowski
2019-02-08 10:31 ` Viresh Kumar
2019-02-08 10:42 ` Rafael J. Wysocki
2019-02-08 10:52 ` Rafael J. Wysocki
2019-02-08 11:39 ` Sudeep Holla
2019-02-08 12:03 ` Rafael J. Wysocki
2019-02-08 12:09 ` Sudeep Holla
2019-02-08 12:23 ` Rafael J. Wysocki
2019-02-08 14:28 ` Sudeep Holla
2019-02-08 11:00 ` Sudeep Holla
2019-02-08 11:47 ` Marek Szyprowski
2019-02-08 11:51 ` Sudeep Holla
2019-02-08 12:04 ` Marek Szyprowski
2019-02-08 12:11 ` Rafael J. Wysocki
2019-02-08 12:16 ` Sudeep Holla
2019-02-08 17:41 ` Sudeep Holla
2019-02-11 8:47 ` Viresh Kumar
2019-02-11 14:08 ` Sudeep Holla
2019-02-11 8:44 ` Viresh Kumar
2019-02-11 9:52 ` Marek Szyprowski
2019-02-11 9:55 ` Viresh Kumar
2019-02-11 12:22 ` Marek Szyprowski
2019-02-12 5:08 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201902080937.M1vOJ8vE%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=b.zolnierkie@samsung.com \
--cc=d-gerlach@ti.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®