From: Stephen Hemminger <stephen@networkplumber.org>
To: Kimberly Brown <kimbrownkd@gmail.com>
Cc: Michael Kelley <mikelley@microsoft.com>,
Long Li <longli@microsoft.com>,
Sasha Levin <Alexander.Levin@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0
Date: Fri, 8 Feb 2019 14:28:40 -0800 [thread overview]
Message-ID: <20190208142821.0ccc0d3f@hermes.lan> (raw)
In-Reply-To: <181a0a2a82e1ad0353a7bdd55a3bdaa0891812cd.1549619051.git.kimbrownkd@gmail.com>
On Fri, 8 Feb 2019 04:58:52 -0500
Kimberly Brown <kimbrownkd@gmail.com> wrote:
> Change the monitor_pages index in server_monitor_pending_show() to '0'.
> '0' is the correct monitor_pages index for the server. A comment for the
> monitor_pages field in the vmbus_connection struct definition indicates
> that the 1st page is for parent->child notifications. In addition, the
> server_monitor_latency_show() and server_monitor_conn_id_show()
> functions use monitor_pages index '0'.
>
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> ---
> drivers/hv/vmbus_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 403fee01572c..f2a79f5129d7 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -234,7 +234,7 @@ static ssize_t server_monitor_pending_show(struct device *dev,
> return -ENODEV;
> return sprintf(buf, "%d\n",
> channel_pending(hv_dev->channel,
> - vmbus_connection.monitor_pages[1]));
> + vmbus_connection.monitor_pages[0]));
> }
> static DEVICE_ATTR_RO(server_monitor_pending);
Looks good.
I wonder if ever gets used though since it returned incorrect data...
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2019-02-08 22:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 9:57 [PATCH 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data Kimberly Brown
2019-02-08 9:58 ` [PATCH 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0 Kimberly Brown
2019-02-08 22:28 ` Stephen Hemminger [this message]
2019-02-08 10:01 ` [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set Kimberly Brown
2019-02-08 22:32 ` Stephen Hemminger
2019-02-11 7:01 ` Kimberly Brown
2019-02-11 18:02 ` Stephen Hemminger
2019-02-14 6:11 ` Kimberly Brown
2019-02-14 19:50 ` Stephen Hemminger
2019-02-19 5:37 ` [PATCH v2 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data Kimberly Brown
2019-02-19 5:38 ` [PATCH v2 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0 Kimberly Brown
2019-02-20 14:35 ` Michael Kelley
[not found] ` <cover.1550554279.git.kimbrownkd@gmail.com>
2019-02-19 5:38 ` [PATCH v2 2/2] Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set Kimberly Brown
2019-02-20 16:11 ` Michael Kelley
2019-02-26 5:35 ` [PATCH v3] Drivers: hv: vmbus: Expose monitor data when channel uses monitor pages Kimberly Brown
2019-02-26 8:18 ` Greg KH
2019-03-01 19:18 ` [PATCH v4] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used Kimberly Brown
2019-03-02 18:39 ` Michael Kelley
2019-03-03 21:40 ` Kimberly Brown
2019-03-03 8:05 ` Greg KH
2019-03-03 21:11 ` Kimberly Brown
2019-03-04 7:38 ` Greg KH
2019-03-08 22:46 ` [PATCH v5] " Kimberly Brown
2019-03-09 7:21 ` Greg KH
2019-03-12 0:04 ` Kimberly Brown
2019-03-19 4:04 ` [PATCH v6] " Kimberly Brown
2019-03-19 9:26 ` Greg KH
2019-03-20 20:18 ` Michael Kelley
2019-03-21 3:57 ` Sasha Levin
2019-03-21 15:55 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208142821.0ccc0d3f@hermes.lan \
--to=stephen@networkplumber.org \
--cc=Alexander.Levin@microsoft.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kimbrownkd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome