mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] parport: daisy: use new parport device model
Date: Mon, 11 Feb 2019 09:38:15 +0100	[thread overview]
Message-ID: <20190211083815.GB5207@kroah.com> (raw)
In-Reply-To: <20190209205907.3770-1-sudipm.mukherjee@gmail.com>

On Sat, Feb 09, 2019 at 08:59:06PM +0000, Sudip Mukherjee wrote:
> -	return bus_register(&parport_bus_type);
> +	int retval;
> +
> +	retval = bus_register(&parport_bus_type);
> +	if (retval)
> +		return retval;
> +#ifdef CONFIG_PARPORT_1284
> +	daisy_drv_init();
> +#endif

Shouldn't you hide these #ifdef lines in the .h file instead of putting
them in the .c file?

thanks,

greg k-h

      parent reply	other threads:[~2019-02-11  8:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 20:59 Sudip Mukherjee
2019-02-09 20:59 ` [PATCH 2/2] parport_pc: fix find_superio io compare code, should use equal test Sudip Mukherjee
2019-02-11  8:38 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211083815.GB5207@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®