mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Changbin Du <changbin.du@gmail.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: print function names instead of just address
Date: Mon, 11 Feb 2019 14:55:32 -0500	[thread overview]
Message-ID: <20190211145532.75d82308@gandalf.local.home> (raw)
In-Reply-To: <20190209161919.32350-1-changbin.du@gmail.com>

On Sun, 10 Feb 2019 00:19:19 +0800
Changbin Du <changbin.du@gmail.com> wrote:

> Here is an example for this change.
> 
> $ sudo perf record -e 'ftrace:function' --filter='ip==schedule'
> $ sudo perf report

I took this but changed the subject as it only affects perf (the kernel
doesn't use the format field for output, and trace-cmd has an internal
plugin that overrides it too).

-- Steve

> 
> The output of perf before this patch:
> 
> \# Samples: 100  of event 'ftrace:function'
> \# Event count (approx.): 100
> \#
> \# Overhead  Trace output
> \# ........  ......................................
> \#
>     51.00%   ffffffff81f6aaa0 <-- ffffffff81158e8d
>     29.00%   ffffffff81f6aaa0 <-- ffffffff8116ccb2
>      8.00%   ffffffff81f6aaa0 <-- ffffffff81f6f2ed
>      4.00%   ffffffff81f6aaa0 <-- ffffffff811628db
>      4.00%   ffffffff81f6aaa0 <-- ffffffff81f6ec5b
>      2.00%   ffffffff81f6aaa0 <-- ffffffff81f6f21a
>      1.00%   ffffffff81f6aaa0 <-- ffffffff811b04af
>      1.00%   ffffffff81f6aaa0 <-- ffffffff8143ce17
> 
> After this patch:
> 
> \# Samples: 36  of event 'ftrace:function'
> \# Event count (approx.): 36
> \#
> \# Overhead  Trace output
> \# ........  ............................................
> \#
>     38.89%   schedule <-- schedule_hrtimeout_range_clock
>     27.78%   schedule <-- worker_thread
>     13.89%   schedule <-- schedule_timeout
>     11.11%   schedule <-- smpboot_thread_fn
>      5.56%   schedule <-- rcu_gp_kthread
>      2.78%   schedule <-- exit_to_usermode_loop
> 
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>  kernel/trace/trace_entries.h | 41 +++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 22 deletions(-)
> 
> 

  reply	other threads:[~2019-02-11 19:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 16:19 Changbin Du
2019-02-11 19:55 ` Steven Rostedt [this message]
2019-02-12  2:58   ` Changbin Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211145532.75d82308@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=changbin.du@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®