From: Christian Brauner <christian@brauner.io>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, mcgrof@kernel.org, longman@redhat.com,
linux@dominikbrodowski.net, keescook@chromium.org,
joe.lawrence@redhat.com, ebiederm@xmission.com
Subject: Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree
Date: Mon, 11 Feb 2019 22:19:19 +0100 [thread overview]
Message-ID: <20190211211917.kq2ahdkhoe36obhp@brauner.io> (raw)
In-Reply-To: <20190211211716.GA31039@avx2>
On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 11, 2019 at 01:06:32PM -0800, akpm@linux-foundation.org wrote:
>
> > @@ -2848,8 +2848,10 @@ static int __do_proc_doulongvec_minmax(v
>
> > - if ((min && val < *min) || (max && val > *max))
> > - continue;
> > + if ((min && val < *min) || (max && val > *max)) {
> > + err = -EINVAL;
>
> I was asked to return ERANGE in kstrto*().
I think we discussed ERANGE vs EINVAL and decided EINVAL because there
was precedence for other sysctls already.
next prev parent reply other threads:[~2019-02-11 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190211210632.Nfd0f%akpm@linux-foundation.org>
2019-02-11 21:17 ` Alexey Dobriyan
2019-02-11 21:19 ` Christian Brauner [this message]
2019-02-11 21:25 ` Luis Chamberlain
2019-02-11 21:32 ` Christian Brauner
2019-02-11 21:41 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211211917.kq2ahdkhoe36obhp@brauner.io \
--to=christian@brauner.io \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=joe.lawrence@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=longman@redhat.com \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®