From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CD2C282C4 for ; Tue, 12 Feb 2019 07:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01E0B2184A for ; Tue, 12 Feb 2019 07:12:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AVzlxxx5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728042AbfBLHMZ (ORCPT ); Tue, 12 Feb 2019 02:12:25 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:36934 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfBLHMY (ORCPT ); Tue, 12 Feb 2019 02:12:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eMDjoxEoIkUplQKJxvXKElX2XrBEFAeIGJy5ImjjJI8=; b=AVzlxxx5ZIYTtcLAxZXMeXljM zQ2dkwWLgx4aUBCCTf21DicM/YUymuUuz5OhEEfeak3Zzv0/YgkdAPnn6nCzn7v+xK8a0zwX9Fl+7 Oki2cLbnwZC2lsqxYe/lAx+rp2K5jJvfZAQoP9ivhUpXNTQFATnroicmYxoQtdLjORnwO9JK0gm7h SUB4ZXSSWmAKY5+XxiJ1jEzVCVcJN3D0++zST+ZqtHcGpZojvKaHI0iLfq9FKL/XDkqmwTivk0w4+ ECTOWjeCiz91VQqUVC4sd70rCekxq6cH73FGoauWFd8P57PCxyz4XUHZVYLhEpO4ua0dwPexQRMaL MexcWFCQw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtSEx-0002w5-Cs; Tue, 12 Feb 2019 07:12:23 +0000 Date: Mon, 11 Feb 2019 23:12:23 -0800 From: Christoph Hellwig To: Johan Hovold Cc: Palmer Dabbelt , Albert Ou , Andreas Schwab , linux-kernel@vger.kernel.org, Atish Patra , Anup Patel , linux-riscv@lists.infradead.org Subject: Re: [PATCH 3/5] riscv: fix riscv_of_processor_hartid() comment Message-ID: <20190212071223.GJ26747@infradead.org> References: <20190118140308.9599-1-johan@kernel.org> <20190118140308.9599-4-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190118140308.9599-4-johan@kernel.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 18, 2019 at 03:03:06PM +0100, Johan Hovold wrote: > The riscv_of_processor_hartid() helper returns -ENODEV when the > specified node isn't an enabled and valid RISC-V hart node. > > Also drop the unnecessary parenthesis around errno defines. > > Signed-off-by: Johan Hovold Looks good, Reviewed-by: Christoph Hellwig