From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79617C282C4 for ; Tue, 12 Feb 2019 18:20:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 510F1222BB for ; Tue, 12 Feb 2019 18:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730436AbfBLSUq (ORCPT ); Tue, 12 Feb 2019 13:20:46 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:41790 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbfBLSUq (ORCPT ); Tue, 12 Feb 2019 13:20:46 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9545CA78; Tue, 12 Feb 2019 10:20:45 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A58303F575; Tue, 12 Feb 2019 10:20:43 -0800 (PST) Date: Tue, 12 Feb 2019 18:20:41 +0000 From: Sudeep Holla To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Linux PM , Greg Kroah-Hartman , Jisheng Zhang , Ulf Hansson , Steve Longerbeam , Eugeniu Rosca , Joshua Frkuska , Eugeniu Rosca Subject: Re: [PATCH] drivers: base: add support to skip power management in device/driver model Message-ID: <20190212182041.GB19095@e107155-lin> References: <20190206150935.12140-1-sudeep.holla@arm.com> <20190207103600.GA14464@e107155-lin> <20190207150638.GB14464@e107155-lin> <20190207152908.GC14464@e107155-lin> <20190212174937.GA19095@e107155-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 12, 2019 at 07:07:31PM +0100, Rafael J. Wysocki wrote: > On Tue, Feb 12, 2019 at 6:49 PM Sudeep Holla wrote: > > > > On Mon, Feb 11, 2019 at 05:20:20PM +0100, Ulf Hansson wrote: > > > On Thu, 7 Feb 2019 at 16:29, Sudeep Holla wrote: > > > > > > > > On Thu, Feb 07, 2019 at 04:18:57PM +0100, Ulf Hansson wrote: > > > > > On Thu, 7 Feb 2019 at 16:06, Sudeep Holla wrote: > > > > > > > > [...] > > > > > > > > > > Indeed, I was ignoring knowing that it's harmless. But more people > > > > > > started to complain, and Rafael suggested this which I agree as we > > > > > > have several pseudo devices created in the kernel that we can bypass > > > > > > some of these pm handling knowing we won't need it. > > > > > > > > > > Okay, I see. > > > > > > > > > > Anyway, I will likely need to restore part of this change, via my > > > > > cluster idling series then. As from that point, the cpu device that > > > > > you call device_set_pm_not_required() for, starts to be used from both > > > > > PM core and runtime PM point of view. But I guess that's okay then. > > > > > > > > > > > > > Ah I see. I can drop for CPU devices then. Since I didn't see any use for > > > > them, I set the flag, but I can drop it now or you can do that as part > > > > of that series. > > > > > > Well, I prefer if you drop it for CPU devices, as least for now. > > > > > > > There are quite a few devices(especially the ones > > > > registered under system subsys can set this but I would take it separate > > > > once we settle on this). Also Rafael may have seen use for few more > > > > devices when he suggested this. > > > > > > Yep, let's find another first user of this. > > > > > > Additionally, it seems like we should drop the print in device_pm_add(). > > > > > > > Hi Rafael, > > > > Do you prefer to drop the error message or retain it as is ? > > Do you mean the one in device_pm_add()? > Yes, the warning "parent should not be sleeping" in device_pm_add(). I would prefer to keep it as is for now. Just asking since Ulf was suggesting to drop them. Regards, Sudeep