From: Greg KH <gregkh@linuxfoundation.org>
To: xiang xiao <xiaoxiang781216@gmail.com>
Cc: alexander.shishkin@linux.intel.com,
andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org,
Xiang Xiao <xiaoxiang@xiaomi.com>
Subject: Re: [PATCH] lib/string: add memrchr function
Date: Tue, 12 Feb 2019 20:15:35 +0100 [thread overview]
Message-ID: <20190212191535.GA22741@kroah.com> (raw)
In-Reply-To: <CAH2Cfb_ZQiHiL2pGCB4j2a3U60=78w6a9if_Z+pgk2qEi+8pZQ@mail.gmail.com>
On Wed, Feb 13, 2019 at 03:09:19AM +0800, xiang xiao wrote:
> On Wed, Feb 13, 2019 at 2:34 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Feb 13, 2019 at 02:06:49AM +0800, Xiang Xiao wrote:
> > > Here is the detailed description for memrchr:
> > > https://linux.die.net/man/3/memrchr
> >
> > Please put it in the changelog, as web pages move and go away :(
>
> Sure.
>
> >
> > >
> > > Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
> > > ---
> > > include/linux/string.h | 1 +
> > > lib/string.c | 21 +++++++++++++++++++++
> > > 2 files changed, 22 insertions(+)
> > >
> > > diff --git a/include/linux/string.h b/include/linux/string.h
> > > index 7927b87..f380f4b 100644
> > > --- a/include/linux/string.h
> > > +++ b/include/linux/string.h
> > > @@ -167,6 +167,7 @@ static inline void memcpy_flushcache(void *dst, const void *src, size_t cnt)
> > > memcpy(dst, src, cnt);
> > > }
> > > #endif
> > > +void *memrchr(const void *s, int c, size_t n);
> >
> > Who is going to use this?
>
> This patch will use memrchr:
> https://github.com/thesofproject/linux/pull/177/commits/a0b7009fede5552dc98733f2996a8140bff62455
> I am preparing to upstream it.
Great, make it part of the patch series for your driver, no need to
submit it separately.
thanks,
greg k-h
next prev parent reply other threads:[~2019-02-12 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 18:06 Xiang Xiao
2019-02-12 18:34 ` Greg KH
2019-02-12 19:09 ` xiang xiao
2019-02-12 19:15 ` Greg KH [this message]
2019-02-12 19:22 ` xiang xiao
2019-02-12 18:54 ` [v2] " Xiang Xiao
2019-02-12 19:11 ` Greg KH
2019-02-12 19:12 ` Greg KH
2019-02-12 19:19 ` xiang xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212191535.GA22741@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoxiang781216@gmail.com \
--cc=xiaoxiang@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®