From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Kangjie Lu <kjlu@umn.edu>, Lee Jones <lee.jones@linaro.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.9 08/21] mfd: mc13xxx: Fix a missing check of a register-read failure
Date: Tue, 12 Feb 2019 21:40:27 -0500 [thread overview]
Message-ID: <20190213024040.21740-8-sashal@kernel.org> (raw)
In-Reply-To: <20190213024040.21740-1-sashal@kernel.org>
From: Kangjie Lu <kjlu@umn.edu>
[ Upstream commit 9e28989d41c0eab57ec0bb156617a8757406ff8a ]
When mc13xxx_reg_read() fails, "old_adc0" is uninitialized and will
contain random value. Further execution uses "old_adc0" even when
mc13xxx_reg_read() fails.
The fix checks the return value of mc13xxx_reg_read(), and exits
the execution when it fails.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/mfd/mc13xxx-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
index d7f54e492aa6..6c16f170529f 100644
--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -274,7 +274,9 @@ int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode,
mc13xxx->adcflags |= MC13XXX_ADC_WORKING;
- mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0);
+ ret = mc13xxx_reg_read(mc13xxx, MC13XXX_ADC0, &old_adc0);
+ if (ret)
+ goto out;
adc0 = MC13XXX_ADC0_ADINC1 | MC13XXX_ADC0_ADINC2;
adc1 = MC13XXX_ADC1_ADEN | MC13XXX_ADC1_ADTRIGIGN | MC13XXX_ADC1_ASC;
--
2.19.1
next prev parent reply other threads:[~2019-02-13 2:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 2:40 [PATCH AUTOSEL 4.9 01/21] mfd: ti_am335x_tscadc: Use PLATFORM_DEVID_AUTO while registering mfd cells Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 02/21] mfd: twl-core: Fix section annotations on {,un}protect_pm_master Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 03/21] mfd: db8500-prcmu: Fix some section annotations Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 04/21] mfd: mt6397: Do not call irq_domain_remove if PMIC unsupported Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 05/21] mfd: ab8500-core: Return zero in get_register_interruptible() Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 06/21] mfd: qcom_rpm: write fw_version to CTRL_REG Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 07/21] mfd: wm5110: Add missing ASRC rate register Sasha Levin
2019-02-13 2:40 ` Sasha Levin [this message]
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 09/21] qed: Fix qed_ll2_post_rx_buffer_notify_fw() by adding a write memory barrier Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 10/21] net: hns: Fix use after free identified by SLUB debug Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 11/21] MIPS: ath79: Enable OF serial ports in the default config Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 12/21] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 13/21] scsi: isci: initialize shost fully before calling scsi_add_host() Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 14/21] MIPS: jazz: fix 64bit build Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 15/21] net: stmmac: Fix PCI module removal leak Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 16/21] isdn: i4l: isdn_tty: Fix some concurrency double-free bugs Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 17/21] atm: he: fix sign-extension overflow on large shift Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 18/21] leds: lp5523: fix a missing check of return value of lp55xx_read Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 19/21] mlxsw: spectrum_switchdev: Do not treat static FDB entries as sticky Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 20/21] net/mlx5e: Fix wrong (zero) TX drop counter indication for representor Sasha Levin
2019-02-13 2:40 ` [PATCH AUTOSEL 4.9 21/21] isdn: avm: Fix string plus integer warning from Clang Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213024040.21740-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=kjlu@umn.edu \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®