From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E351C282CA for ; Wed, 13 Feb 2019 02:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3E21222C1 for ; Wed, 13 Feb 2019 02:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025731; bh=99+BfMYDuIJoLahaLuDtxEdUCdONFyUhXM7yPERbqf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NDZIBBuDrKrxqwDJQ/noD7YY3u/xLTqmTXdR6EKk/aJveZ+6HzlNxxzN8Ytpqokh/ pg3Y0KH5TfhltJYT5X98Kr1eQkoaUBsl/EEJTFPtaUUNxBBI+TqxYtuX+JmW/5rdhe KucNkb1A/gFXKAaBTQUrGVxQzGgnEKIsYZ9wXhfk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389460AbfBMCmE (ORCPT ); Tue, 12 Feb 2019 21:42:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:45640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389416AbfBMCl7 (ORCPT ); Tue, 12 Feb 2019 21:41:59 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C89972175B; Wed, 13 Feb 2019 02:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025718; bh=99+BfMYDuIJoLahaLuDtxEdUCdONFyUhXM7yPERbqf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v9rA45mS5VJ9VsAWadjW1UaexowcmQ1Ezev1MK9j93KFT3eMv0meWLzw9Gp4ERxFq vjorSOo3dMY8evRvRRdc5LfDgZbnRW9SGuPKxN++kQqT9zzA/HlPMiiRhJ4x3U/zxK WHJhrCx2plFQD4XbX2cZQlYm0cIPleEYeIR4KAZ4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , Jacek Anaszewski , Sasha Levin , linux-leds@vger.kernel.org Subject: [PATCH AUTOSEL 3.18 13/14] leds: lp5523: fix a missing check of return value of lp55xx_read Date: Tue, 12 Feb 2019 21:41:37 -0500 Message-Id: <20190213024139.22268-13-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190213024139.22268-1-sashal@kernel.org> References: <20190213024139.22268-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit 248b57015f35c94d4eae2fdd8c6febf5cd703900 ] When lp55xx_read() fails, "status" is an uninitialized variable and thus may contain random value; using it leads to undefined behaviors. The fix inserts a check for the return value of lp55xx_read: if it fails, returns with its error code. Signed-off-by: Kangjie Lu Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/leds-lp5523.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 9e1716f8098c..20e43f8b9325 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -313,7 +313,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) /* Let the programs run for couple of ms and check the engine status */ usleep_range(3000, 6000); - lp55xx_read(chip, LP5523_REG_STATUS, &status); + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); + if (ret) + return ret; status &= LP5523_ENG_STATUS_MASK; if (status != LP5523_ENG_STATUS_MASK) { -- 2.19.1