From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD27BC282C4 for ; Wed, 13 Feb 2019 02:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F5472175B for ; Wed, 13 Feb 2019 02:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025747; bh=qf2rNdHS0WitkPI8RPDq7IavBuHpPYlPlB54nYWYvC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vICDrASN9XirBEruq78ea4JK2mkZwNGyFOB4Gc0FeVVzhyvng2d/CNI0Zte+QS9fu LUK03bLGDnn+uo0D3TVXxtmgiGGxEYO40YsKWJ/DGekWXtqdwsD1W/yu9v7B+l2aio zdHZ77Vg4iAy24lsoPe3uPJCKHW++2uqM5OBCvhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389414AbfBMCl6 (ORCPT ); Tue, 12 Feb 2019 21:41:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:45518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389371AbfBMClu (ORCPT ); Tue, 12 Feb 2019 21:41:50 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF3BB222C2; Wed, 13 Feb 2019 02:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025709; bh=qf2rNdHS0WitkPI8RPDq7IavBuHpPYlPlB54nYWYvC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKA266/+wURwUnosR137tlOmPfGhD0xCVDrI6GwZ32Q02l5avriyBRk6aaoCCPB1+ TX/n6JzORIpYLhYphUYKk1D2ItEm12+erEVZUNVI41GHOZAVx9oB8e7NjIg6E0HJpm /O6AhoV/f9MQanejJ5XPrAB+TPfzwsgr0e1HQJbg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: YueHaibing , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 3.18 08/14] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param Date: Tue, 12 Feb 2019 21:41:32 -0500 Message-Id: <20190213024139.22268-8-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190213024139.22268-1-sashal@kernel.org> References: <20190213024139.22268-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 72b4a0465f995175a2e22cf4a636bf781f1f28a7 ] The return code should be check while qla4xxx_copy_from_fwddb_param fails. Signed-off-by: YueHaibing Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index d0cad6fc598e..a9fac1eb8306 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -7251,6 +7251,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha, rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn, fw_ddb_entry); + if (rc) + goto free_sess; ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n", __func__, fnode_sess->dev.kobj.name); -- 2.19.1