From: Lee Jones <lee.jones@linaro.org>
To: Stuart Menefy <stuart.menefy@mathembedded.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2] mfd: sec: Add support for the RTC on S2MPA01
Date: Wed, 13 Feb 2019 07:24:58 +0000 [thread overview]
Message-ID: <20190213072458.GB1863@dell> (raw)
In-Reply-To: <20190212214639.9613-1-stuart.menefy@mathembedded.com>
Good morning Stuart,
It's been a while. I hope all is well with you.
> The RTC portion of the S2MPA01 appears to have the same
> register layout as the S2MPS14.
>
> Signed-off-by: Stuart Menefy <stuart.menefy@mathembedded.com>
> ---
> drivers/mfd/sec-core.c | 2 ++
> drivers/mfd/sec-irq.c | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index e0835c9df7a1..08621ef5d822 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -103,6 +103,8 @@ static const struct mfd_cell s2mps15_devs[] = {
> static const struct mfd_cell s2mpa01_devs[] = {
> {
> .name = "s2mpa01-pmic",
> + }, {
> + .name = "s2mps14-rtc",
> },
> };
Ideally one line entries should be on one line (see: s2mps13_devs).
Would you like to take a couple of minutes to make those changes
file-wide and rework this patch on top of it please?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-13 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 21:46 Stuart Menefy
2019-02-13 7:24 ` Lee Jones [this message]
2019-02-13 8:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213072458.GB1863@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
--cc=stuart.menefy@mathembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®