From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D93AC282C2 for ; Wed, 13 Feb 2019 14:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAE99222B2 for ; Wed, 13 Feb 2019 14:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391482AbfBMOCY convert rfc822-to-8bit (ORCPT ); Wed, 13 Feb 2019 09:02:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:45596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732447AbfBMOCU (ORCPT ); Wed, 13 Feb 2019 09:02:20 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D61A20836; Wed, 13 Feb 2019 14:02:19 +0000 (UTC) Date: Wed, 13 Feb 2019 09:02:17 -0500 From: Steven Rostedt To: "Gustavo A. R. Silva" Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH] tracing: Mark expected switch fall-through Message-ID: <20190213090217.52eb48e8@gandalf.local.home> In-Reply-To: <20190212210803.GA8543@embeddedor> References: <20190212210803.GA8543@embeddedor> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Feb 2019 15:08:03 -0600 "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > kernel/trace/trace_events_filter.c: In function ‘predicate_parse’: > kernel/trace/trace_events_filter.c:494:8: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (next[1] == next[0]) { > ^ > kernel/trace/trace_events_filter.c:498:4: note: here > default: > ^~~~~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > Thanks, but I've already applied this patch: http://lkml.kernel.org/r/20190114203039.16535-2-malat@debian.org I just haven't run my queue through my tests to push it to linux-next yet. -- Steve > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva > --- > kernel/trace/trace_events_filter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c > index 27821480105e..eb694756c4bb 100644 > --- a/kernel/trace/trace_events_filter.c > +++ b/kernel/trace/trace_events_filter.c > @@ -495,6 +495,7 @@ predicate_parse(const char *str, int nr_parens, int nr_preds, > ptr++; > break; > } > + /* fall through */ > default: > parse_error(pe, FILT_ERR_TOO_MANY_PREDS, > next - str);