From: Peng Fan <peng.fan@nxp.com>
To: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"yaojun8558363@gmail.com" <yaojun8558363@gmail.com>,
"cpandya@codeaurora.org" <cpandya@codeaurora.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"van.freenix@gmail.com" <van.freenix@gmail.com>,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 3/3] arm64: mmu: pgd_pgtable_alloc: drop barrier
Date: Wed, 13 Feb 2019 09:37:38 +0000 [thread overview]
Message-ID: <20190213094831.7292-3-peng.fan@nxp.com> (raw)
In-Reply-To: <20190213094831.7292-1-peng.fan@nxp.com>
The barriers are added for empty_zero_page, however the
empty zero page has been moved to bss area by
commit 5227cfa71f9e ("arm64: mm: place empty_zero_page in bss"),
and it alreay added "dsb ishst" in head.S to make sure
the empty zero page visible to PTW.
pgd_pgtable_alloc is only called by __create_pgd_mapping, and
there are implicit barriers in __create_pgd_mapping, so we
could remove the barrier pgd_pgtable_alloc
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Note: this patch tested on qemu-system-aarch64, not real hardware.
arch/arm64/mm/mmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index f61fa7c8fd2e..04e3d4d070ce 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -371,8 +371,6 @@ static phys_addr_t pgd_pgtable_alloc(void)
if (!ptr || !pgtable_page_ctor(virt_to_page(ptr)))
BUG();
- /* Ensure the zeroed page is visible to the page table walker */
- dsb(ishst);
return __pa(ptr);
}
--
2.16.4
next prev parent reply other threads:[~2019-02-13 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:37 [PATCH 1/3] arm64: mmu: update paging_init comments Peng Fan
2019-02-13 9:37 ` [PATCH 2/3] arm64: mmu: early_pgtable_alloc: remove unnecessary comments Peng Fan
2019-02-13 11:21 ` Mark Rutland
2019-02-13 11:50 ` Peng Fan
2019-02-13 9:37 ` Peng Fan [this message]
2019-02-13 11:30 ` [PATCH 3/3] arm64: mmu: pgd_pgtable_alloc: drop barrier Mark Rutland
2019-02-13 11:54 ` Peng Fan
2019-02-13 11:18 ` [PATCH 1/3] arm64: mmu: update paging_init comments Mark Rutland
2019-02-13 11:49 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213094831.7292-3-peng.fan@nxp.com \
--to=peng.fan@nxp.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=van.freenix@gmail.com \
--cc=will.deacon@arm.com \
--cc=yaojun8558363@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®