From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BB3C282CA for ; Wed, 13 Feb 2019 11:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82E8D2075C for ; Wed, 13 Feb 2019 11:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403881AbfBMLS6 (ORCPT ); Wed, 13 Feb 2019 06:18:58 -0500 Received: from foss.arm.com ([217.140.101.70]:51912 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728454AbfBMLS4 (ORCPT ); Wed, 13 Feb 2019 06:18:56 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E69951596; Wed, 13 Feb 2019 03:18:55 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2603B3F774; Wed, 13 Feb 2019 03:18:54 -0800 (PST) Date: Wed, 13 Feb 2019 11:18:42 +0000 From: Mark Rutland To: Peng Fan Cc: "catalin.marinas@arm.com" , "will.deacon@arm.com" , "ard.biesheuvel@linaro.org" , "yaojun8558363@gmail.com" , "cpandya@codeaurora.org" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "van.freenix@gmail.com" Subject: Re: [PATCH 1/3] arm64: mmu: update paging_init comments Message-ID: <20190213111841.GA22119@lakrids.cambridge.arm.com> References: <20190213094831.7292-1-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213094831.7292-1-peng.fan@nxp.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 13, 2019 at 09:37:24AM +0000, Peng Fan wrote: > The comments has not been changed since the function introduced, but the > function has been changed dramatically, so update the comments to > reflect the code. > > Signed-off-by: Peng Fan > --- > arch/arm64/mm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index d6b6f1b169bb..065202da3ad2 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -655,8 +655,8 @@ static void __init map_kernel(pgd_t *pgdp) > } > > /* > - * paging_init() sets up the page tables, initialises the zone memory > - * maps and sets up the zero page. > + * paging_init() sets up the page tables, switch ttbr1 from init_pg_dir > + * to swapper_pg_dir, free init_pg_dir memblock and permit memblock resizing. > */ I think that it would be better to remove the comment entirely. This doesn't explain the intent, or rationale, and all this information is obvious from a straight-line reading of the code. If you remove the comment instead: Acked-by: Mark Rutland Mark. > void __init paging_init(void) > { > -- > 2.16.4 >