From: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
To: platform-driver-x86@vger.kernel.org
Cc: dvhart@infradead.org, andy@infradead.org,
linux-kernel@vger.kernel.org,
Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>,
"David E. Box" <david.e.box@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v2 04/10] platform/x86: intel_pmc_core: Fix file permissions for ltr_show
Date: Wed, 13 Feb 2019 20:38:04 +0530 [thread overview]
Message-ID: <20190213150810.32750-5-rajneesh.bhardwaj@linux.intel.com> (raw)
In-Reply-To: <20190213150810.32750-1-rajneesh.bhardwaj@linux.intel.com>
File permissions for ltr_show attribute should be similar to other
debugfs attributes created by this driver. '0644' should be used only
when there is a write operation desired such as for ltr_ignore.
Cc: "David E. Box" <david.e.box@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[rajneesh: folded in correct SHA1 as reported by Stephen Rothwell]
Fixes: 2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info")
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
---
drivers/platform/x86/intel_pmc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 80936e6bdc61..125461ca2927 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -702,7 +702,7 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
debugfs_create_file("ltr_ignore", 0644, dir, pmcdev,
&pmc_core_ltr_ignore_ops);
- debugfs_create_file("ltr_show", 0644, dir, pmcdev, &pmc_core_ltr_fops);
+ debugfs_create_file("ltr_show", 0444, dir, pmcdev, &pmc_core_ltr_fops);
if (pmcdev->map->pll_sts)
debugfs_create_file("pll_status", 0444, dir, pmcdev,
--
2.17.1
next prev parent reply other threads:[~2019-02-13 15:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 15:08 [PATCH v2 00/10] ICL support and other enhancements for PMC Core Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 01/10] platform/x86: intel_pmc_core: Handle CFL regmap properly Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 02/10] platform/x86: intel_pmc_core: Fix PCH IP sts reading Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 03/10] platform/x86: intel_pmc_core: Fix PCH IP name Rajneesh Bhardwaj
2019-02-13 15:08 ` Rajneesh Bhardwaj [this message]
2019-02-13 15:08 ` [PATCH v2 05/10] platform/x86: intel_pmc_core: Include Reserved IP for LTR Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 06/10] x86/cpu: Add Icelake to Intel family Rajneesh Bhardwaj
2019-02-13 15:23 ` Borislav Petkov
2019-02-13 15:43 ` Bhardwaj, Rajneesh
2019-02-13 16:04 ` Borislav Petkov
2019-02-13 16:35 ` Bhardwaj, Rajneesh
2019-02-13 16:40 ` Dave Hansen
2019-02-13 17:13 ` Bhardwaj, Rajneesh
2019-02-13 17:18 ` Borislav Petkov
2019-02-13 15:08 ` [PATCH v2 07/10] platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 08/10] platform/x86: intel_pmc_core: Add ICL platform support Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 09/10] platform/x86: intel_pmc_core: Add Package cstates residency info Rajneesh Bhardwaj
2019-02-13 15:08 ` [PATCH v2 10/10] platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown Rajneesh Bhardwaj
2019-02-13 15:21 ` Mario.Limonciello
2019-02-13 15:31 ` Bhardwaj, Rajneesh
2019-02-13 15:33 ` [PATCH v2 00/10] ICL support and other enhancements for PMC Core Andy Shevchenko
2019-02-13 15:49 ` Bhardwaj, Rajneesh
2019-02-13 17:28 ` Andy Shevchenko
2019-02-13 18:02 ` Bhardwaj, Rajneesh
2019-02-13 18:13 ` Andy Shevchenko
2019-02-13 18:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213150810.32750-5-rajneesh.bhardwaj@linux.intel.com \
--to=rajneesh.bhardwaj@linux.intel.com \
--cc=andy@infradead.org \
--cc=david.e.box@intel.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®