mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hedi Berriche <hedi.berriche@hpe.com>
To: linux-kernel@vger.kernel.org,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Bhupesh Sharma <bhsharma@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-efi@vger.kernel.org, x86@kernel.org,
	Russ Anderson <rja@hpe.com>, Mike Travis <mike.travis@hpe.com>,
	Dimitri Sivanich <sivanich@hpe.com>,
	Steve Wahl <steve.wahl@hpe.com>,
	stable@vger.kernel.org
Subject: [Patch v3 3/4] x86/platform/UV: use efi_enabled() instead of test_bit()
Date: Wed, 13 Feb 2019 19:34:12 +0000	[thread overview]
Message-ID: <20190213193413.25560-4-hedi.berriche@hpe.com> (raw)
In-Reply-To: <20190213193413.25560-1-hedi.berriche@hpe.com>

Use ad hoc efi_enabled() instead of fiddling with test_bit().

Cleanup, no functional changes.

Cc: Russ Anderson <rja@hpe.com>
Cc: Mike Travis <mike.travis@hpe.com>
Cc: Dimitri Sivanich <sivanich@hpe.com>
Cc: Steve Wahl <steve.wahl@hpe.com>
Cc: stable@vger.kernel.org # v4.9+
Signed-off-by: Hedi Berriche <hedi.berriche@hpe.com>
---
 arch/x86/platform/uv/bios_uv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c
index 91e3d5285836..38a2e3431fc6 100644
--- a/arch/x86/platform/uv/bios_uv.c
+++ b/arch/x86/platform/uv/bios_uv.c
@@ -44,7 +44,7 @@ s64 uv_bios_call(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3, u64 a4, u64 a5)
 	 * If EFI_OLD_MEMMAP is set, we need to fall back to using our old EFI
 	 * callback method, which uses efi_call() directly, with the kernel page tables:
 	 */
-	if (unlikely(test_bit(EFI_OLD_MEMMAP, &efi.flags)))
+	if (unlikely(efi_enabled(EFI_OLD_MEMMAP)))
 		ret = efi_call((void *)__va(tab->function), (u64)which, a1, a2, a3, a4, a5);
 	else
 		ret = efi_call_virt_pointer(tab, function, (u64)which, a1, a2, a3, a4, a5);
-- 
2.20.1


  parent reply	other threads:[~2019-02-13 19:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 19:34 [Patch v3 0/4] Protect against concurrent calls into UV BIOS Hedi Berriche
2019-02-13 19:34 ` [Patch v3 1/4] x86/platform/UV: remove unnecessary #ifdef CONFIG_EFI Hedi Berriche
2019-02-15 15:04   ` [tip:x86/uv] x86/platform/UV: Remove " tip-bot for Hedi Berriche
2019-02-13 19:34 ` [Patch v3 2/4] x86/platform/UV: kill uv_bios_call_reentrant() Hedi Berriche
2019-02-15 15:04   ` [tip:x86/uv] x86/platform/UV: Remove uv_bios_call_reentrant() tip-bot for Hedi Berriche
2019-02-13 19:34 ` Hedi Berriche [this message]
2019-02-15 15:05   ` [tip:x86/uv] x86/platform/UV: Use efi_enabled() instead of test_bit() tip-bot for Hedi Berriche
2019-02-13 19:34 ` [Patch v3 4/4] x86/platform/UV: use efi_runtime_lock to serialise BIOS calls Hedi Berriche
2019-02-15 15:01   ` [tip:x86/urgent] x86/platform/UV: Use " tip-bot for Hedi Berriche
2019-02-14  8:17 ` [Patch v3 0/4] Protect against concurrent calls into UV BIOS Ard Biesheuvel
2019-02-14 21:08   ` Russ Anderson
2019-02-14 21:21 ` Dimitri Sivanich
2019-02-14 21:31   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213193413.25560-4-hedi.berriche@hpe.com \
    --to=hedi.berriche@hpe.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhsharma@redhat.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=mingo@redhat.com \
    --cc=rja@hpe.com \
    --cc=sivanich@hpe.com \
    --cc=stable@vger.kernel.org \
    --cc=steve.wahl@hpe.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®