mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	julien.thierry@arm.com,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Coresight ML <coresight@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [v5.0-rc6 regression] "perf/core: Don't WARN() for impossible ring-buffer sizes"
Date: Thu, 14 Feb 2019 07:38:27 +0800	[thread overview]
Message-ID: <20190213233827.GA9483@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <CANLsYkynsuO7mQxnfSrctOtUtjeokgMX5f9hqG0muufJsKfdbA@mail.gmail.com>

Hi Mathieu, Mark,

On Wed, Feb 13, 2019 at 02:26:25PM -0700, Mathieu Poirier wrote:
> Hi Mark,
> 
> CoreSight trace collection is broken on v5.0-rc6 due to this commit:
> 
> 9dff0aa95a32 perf/core: Don't WARN() for impossible ring-buffer sizes
> 
> Before:
> root@juno:/home/linaro# perf record -e cs_etm/@20070000.etr/u
> --per-thread  uname
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.036 MB perf.data ]
> root@juno:/home/linaro#
> 
> After:
> root@juno:/home/linaro# perf record -e cs_etm/@20070000.etr/u
> --per-thread  uname
> failed to mmap with 12 (Cannot allocate memory)
> root@juno:/home/linaro#
> 
> The problem is related to the order_base_2() [1] test with a size of
> 1264, stemming from nr_pages equal to 128.  The combination yields an
> order of 11, something leading directly to the error path.
> 
> The results are the same with linux-next 20190213.  This was tested on
> a Juno R0 and R1 with a 4K page configuration.  I haven't tried but
> I'm pretty sure it breaks IntelPT as well.

I noticed in another thread [1] Peter gave out the fixing for this
issue; applied this fixing on my local code and it fixes CoreSight
tracing issue.

Thanks,
Leo Yan

[1] https://lkml.org/lkml/2019/2/12/452

      reply	other threads:[~2019-02-13 23:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 21:26 Mathieu Poirier
2019-02-13 23:38 ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213233827.GA9483@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=julien.thierry@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®