From: CHANDAN VN <chandan.vn@samsung.com>
To: Mike Rapoport <rppt@linux.ibm.com>,
Christoph Hellwig <hch@infradead.org>
Cc: Anup Patel <Anup.Patel@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Laura Abbott <labbott@redhat.com>,
Will Deacon <will.deacon@arm.com>
Subject: RE: Re: [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem()
Date: Thu, 14 Feb 2019 10:30:04 +0530 [thread overview]
Message-ID: <20190214050004epcms5p4d2157380c40e9b218fb0eeb376b3cb7c@epcms5p4> (raw)
In-Reply-To: <20190213180557.GA15270@rapoport-lnx>
Hi,
> On Wed, Feb 13, 2019 at 09:54:15AM -0800, Christoph Hellwig wrote:
> > On Wed, Feb 13, 2019 at 09:38:36AM +0200, Mike Rapoport wrote:
> > > memblock_free() is has no real effect at this point, no idea why arm64
> > > calls it.
> >
> > Looks like the call was added fairly recently by:
> >
> > commit 05c58752f9dce11e396676eb731a620541590ed0
> > Author: CHANDAN VN <chandan.vn@samsung.com>
> > Date: Mon Apr 30 09:50:18 2018 +0530
> >
> > arm64: To remove initrd reserved area entry from memblock
> >
> > which claims it is to work around the initrd being displayed in
> > /sys/kernel/debug/memblock/reserved.
> >
> > I really think we need to have common behavior there - either do this
> > for all architectures or none. I've just sent a series that
> > consolidates all but a handful of the free_initrd_mem, so implementing
> > any common behavior on top of that would be good.
>
> I've just started to look into it today :)
> I'll reply on that thread.
INITRD reserved area entry is not removed from memblock
even though initrd reserved area is freed. The same can be
checked from /sys/kernel/debug/memblock/reserved.
We did not face this issue on arm32 architecture.
Though the changes which i had submitted does not fix any memory leak,
it does make sure that the entries freed from memblock are actually removed
from the sys entry as well.
Also the implementation of arm64 is quite different from arm32. I feel a generic
implementation can be taken up only if its a real necessity.
prev parent reply other threads:[~2019-02-14 5:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 6:31 [PATCH v4 0/6] Fixmap support and MM cleanups Anup Patel
2019-02-13 6:32 ` [PATCH v4 1/6] RISC-V: Move free_initrd_mem() to kernel/setup.c Anup Patel
2019-02-13 6:32 ` [PATCH v4 2/6] RISC-V: Setup init_mm before parse_early_param() Anup Patel
2019-02-13 6:32 ` [PATCH v4 3/6] RISC-V: Move setup_bootmem() to mm/init.c Anup Patel
2019-02-13 6:32 ` [PATCH v4 4/6] RISC-V: Move setup_vm() " Anup Patel
2019-02-13 6:32 ` [PATCH v4 5/6] RISC-V: Implement compile-time fixed mappings Anup Patel
2019-02-13 6:32 ` [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem() Anup Patel
2019-02-13 6:44 ` Christoph Hellwig
2019-02-13 7:38 ` Mike Rapoport
2019-02-13 7:49 ` Anup Patel
2019-02-13 17:54 ` Christoph Hellwig
2019-02-13 18:05 ` Mike Rapoport
[not found] ` <CGME20190213180621epcas4p44685b5689a3fcfbe63453e808f502548@epcms5p4>
2019-02-14 5:00 ` CHANDAN VN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214050004epcms5p4d2157380c40e9b218fb0eeb376b3cb7c@epcms5p4 \
--to=chandan.vn@samsung.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®