From: Mark Brown <broonie@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: lgirdwood@gmail.com, krzk@kernel.org, sbkim73@samsung.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 Resend 09/13] ASoC: dmaengine: Remove unused SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME flag
Date: Thu, 14 Feb 2019 13:07:47 +0000 [thread overview]
Message-ID: <20190214130747.GA11988@sirena.org.uk> (raw)
In-Reply-To: <20190214093747.2414-10-s.nawrocki@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Thu, Feb 14, 2019 at 10:37:43AM +0100, Sylwester Nawrocki wrote:
> u32 maxburst;
> unsigned int slave_id;
> void *filter_data;
> - const char *chan_name;
> unsigned int fifo_size;
> unsigned int flags;
This fails to build:
CC sound/core/pcm_dmaengine.o
sound/arm/pxa2xx-pcm-lib.c: In function ‘pxa2xx_pcm_open’:
sound/arm/pxa2xx-pcm-lib.c:128:22: error: ‘struct snd_dmaengine_dai_dma_data’ has no member named ‘chan_name’
dma_params->chan_name));
^~
sound/arm/pxa2xx-pcm-lib.c:129:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-14 13:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190214093822epcas2p11380606cb3272aa4fd56eb55dea8f8c8@epcas2p1.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 00/13] ASoC: dmaengine updates, secondary CPU DAI for Odroid Sylwester Nawrocki
[not found] ` <CGME20190214093825epcas1p24af57e964af261c979af4d4cbffcfa6c@epcas1p2.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 01/13] ASoC: samsung: i2s: Move SFR pointer to common driver data structure Sylwester Nawrocki
[not found] ` <CGME20190214093828epcas2p444b9d819fefb0eb730a716589a00218b@epcas2p4.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 02/13] ASoC: samsung: i2s: Drop spinlock pointer from i2s_dai " Sylwester Nawrocki
[not found] ` <CGME20190214093831epcas1p2a42c5b95424a251e7ae38dd21c1a4696@epcas1p2.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 03/13] ASoC: samsung: i2s: Move IP variant data to common driver " Sylwester Nawrocki
[not found] ` <CGME20190214093833epcas2p1cd99c749360aadf06a551810862d9bf4@epcas2p1.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 04/13] ASoC: samsung: i2s: Move quirks " Sylwester Nawrocki
[not found] ` <CGME20190214093836epcas1p36ff39d1a7ae59bf475256c6ae5c6171c@epcas1p3.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 05/13] ASoC: samsung: i2s: Get rid of a static spinlock Sylwester Nawrocki
[not found] ` <CGME20190214093839epcas2p2609ddf53eb48143ff2160d6a30dad615@epcas2p2.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 06/13] ASoC: samsung: odroid: Add support for secondary CPU DAI Sylwester Nawrocki
[not found] ` <CGME20190214093842epcas1p154bd9c945a6897d5211c152aefabb32c@epcas1p1.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 07/13] ASoC: samsung: Specify DMA channel names through custom DMA config Sylwester Nawrocki
[not found] ` <CGME20190214093844epcas1p432e337986df8edc10206413da8a7cd08@epcas1p4.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 08/13] ASoC: samsung: Drop DAI DMA data chan_name assignments Sylwester Nawrocki
[not found] ` <CGME20190214093847epcas2p1056c7371ba485f375a9d408ea45078e4@epcas2p1.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 09/13] ASoC: dmaengine: Remove unused SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME flag Sylwester Nawrocki
2019-02-14 13:07 ` Mark Brown [this message]
2019-02-14 14:32 ` Sylwester Nawrocki
2019-02-14 14:47 ` Mark Brown
[not found] ` <CGME20190214093850epcas1p2ced5d0673c9c4aebe57aa0ab4b08aeaf@epcas1p2.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 10/13] ASoC: samsung: i2s: Simplify pri_dai, sec_dai pointers usage Sylwester Nawrocki
[not found] ` <CGME20190214093853epcas2p2f48340585495bf0ba662ae42399d1cab@epcas2p2.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 11/13] ASoC: samsung: i2s: Change indentation in SAMSUNG_I2S_FMTS definition Sylwester Nawrocki
[not found] ` <CGME20190214093856epcas1p333b119e4b70f2c0edaf0c181e45adfb7@epcas1p3.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 12/13] ASoC: samsung: i2s: Comments clean up Sylwester Nawrocki
[not found] ` <CGME20190214093858epcas2p10993b30cf39b6c12d3fe0a4dfd20f6e8@epcas2p1.samsung.com>
2019-02-14 9:37 ` [PATCH v3 Resend 13/13] ASoC: samsung: i2s: Convert to SPDX License Indentifier Sylwester Nawrocki
2019-02-14 14:51 ` Applied "ASoC: samsung: i2s: Convert to SPDX License Indentifier" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214130747.GA11988@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®