From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 445E1C43381 for ; Thu, 14 Feb 2019 13:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12662222B6 for ; Thu, 14 Feb 2019 13:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392361AbfBNNqV convert rfc822-to-8bit (ORCPT ); Thu, 14 Feb 2019 08:46:21 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41213 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387759AbfBNNqV (ORCPT ); Thu, 14 Feb 2019 08:46:21 -0500 X-Originating-IP: 90.88.30.68 Received: from localhost (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 794B740015; Thu, 14 Feb 2019 13:46:17 +0000 (UTC) Date: Thu, 14 Feb 2019 14:46:17 +0100 From: Maxime Ripard To: Yangtao Li Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64: dts: allwinner: h6: orangepi: Add CPU supply regulator Message-ID: <20190214134617.b44pa7onf3brmhhj@flea> References: <20190214130910.9201-1-tiny.windzz@gmail.com> <20190214130910.9201-2-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20190214130910.9201-2-tiny.windzz@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Thanks for your patches On Thu, Feb 14, 2019 at 08:09:07AM -0500, Yangtao Li wrote: > The original orangepi use the dcdca to supply the CPU cores. According > to the axp805 spec, the range of dcdca is 0.6 to 1.1v, 1.12 to 1.52v. > In order to support more CPU frequency, slightly increase the voltage > maximum and minimum. > > Signed-off-by: Yangtao Li > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > index b2526dac2fcf..e7aebaf91ede 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi > @@ -159,8 +159,8 @@ > > reg_dcdca: dcdca { > regulator-always-on; > - regulator-min-microvolt = <810000>; > - regulator-max-microvolt = <1080000>; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1160000>; This violates the minimum and maximum recommended voltages in the H6 datasheet. Could you clarify why you are doing so (ideally in the commit log)? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com