From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E0BC43381 for ; Sun, 17 Feb 2019 23:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCE0A2184E for ; Sun, 17 Feb 2019 23:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbfBQXeP (ORCPT ); Sun, 17 Feb 2019 18:34:15 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42718 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727102AbfBQXeO (ORCPT ); Sun, 17 Feb 2019 18:34:14 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AEEFE12294510; Sun, 17 Feb 2019 15:34:13 -0800 (PST) Date: Sun, 17 Feb 2019 15:34:13 -0800 (PST) Message-Id: <20190217.153413.776181738897663074.davem@davemloft.net> To: maxime.chevallier@bootlin.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com Subject: Re: [PATCH net-next] net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause From: David Miller In-Reply-To: <20190215083347.5886-1-maxime.chevallier@bootlin.com> References: <20190215083347.5886-1-maxime.chevallier@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 17 Feb 2019 15:34:14 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Chevallier Date: Fri, 15 Feb 2019 09:33:47 +0100 > The PHY core expects PHY drivers not to set Pause and Asym_Pause bits, > unless the driver only wants to specify one of them due to HW > limitation. In the case of the Marvell10g driver, we don't need to set > them. > > Signed-off-by: Maxime Chevallier > Suggested-by: Andrew Lunn Applied, thanks.