mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-rt-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH RT 2/2] x86: lazy-preempt: properly check against preempt-mask
Date: Mon, 18 Feb 2019 17:31:37 +0100	[thread overview]
Message-ID: <20190218163137.cmor4ek3odus5m6j@linutronix.de> (raw)
In-Reply-To: <20190218163107.iwdpngwmbs6xyk7x@linutronix.de>

should_resched() should check against preempt_offset after unmasking the
need-resched-bit. Otherwise should_resched() won't work for
preempt_offset != 0 and lazy-preempt set.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/x86/include/asm/preempt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preempt.h
index 22992c8377952..f667087792747 100644
--- a/arch/x86/include/asm/preempt.h
+++ b/arch/x86/include/asm/preempt.h
@@ -118,7 +118,7 @@ static __always_inline bool should_resched(int preempt_offset)
 
 	/* preempt count == 0 ? */
 	tmp &= ~PREEMPT_NEED_RESCHED;
-	if (tmp)
+	if (tmp != preempt_offset)
 		return false;
 	if (current_thread_info()->preempt_lazy_count)
 		return false;
-- 
2.20.1


  reply	other threads:[~2019-02-18 16:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 16:31 [PATCH RT 1/2] softirq: Avoid "local_softirq_pending" messages if ksoftirqd is blocked Sebastian Andrzej Siewior
2019-02-18 16:31 ` Sebastian Andrzej Siewior [this message]
2019-02-19 16:07   ` [PATCH RT 3/2] softirq: Avoid "local_softirq_pending" messages if task is in cpu_chill() Sebastian Andrzej Siewior
2019-02-19 16:08     ` [PATCH RT 4/2] hrtimer: Don't lose state " Sebastian Andrzej Siewior
2019-02-25 14:43       ` Mike Galbraith
2019-02-25 16:34         ` Sebastian Andrzej Siewior
2019-02-25 17:40           ` Mike Galbraith
2019-02-26 11:38             ` Sebastian Andrzej Siewior
2019-02-19 14:58 ` [PATCH RT 1/2] softirq: Avoid "local_softirq_pending" messages if ksoftirqd is blocked Juri Lelli
2019-02-19 16:06   ` Sebastian Andrzej Siewior
2019-02-19 16:27     ` Juri Lelli
2019-02-19 16:28       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218163137.cmor4ek3odus5m6j@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®