From: Arthur Gautier <baloo@gandi.net>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>, Jann Horn <jannh@google.com>,
the arch/x86 maintainers <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
kernel list <linux-kernel@vger.kernel.org>,
Pascal Bouchareine <pascal@gandi.net>
Subject: Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user
Date: Mon, 18 Feb 2019 21:51:50 +0000 [thread overview]
Message-ID: <20190218215150.xklqbfckwmbtdm3t@khany> (raw)
In-Reply-To: <CALCETrXyard2OXmOafiLks3YuyO=ObbjDXB6NJo_08rL4M6azw@mail.gmail.com>
On Mon, Feb 18, 2019 at 11:15:44AM -0800, Andy Lutomirski wrote:
> This seems like it's just papering over the underlying problem: with
> Jann's new checks in place, strncpy_from_user() is simply buggy. Does
> the patch below look decent? It's only compile-tested, but it's
> conceptually straightforward. I was hoping I could get rid of the
> check-maximum-address stuff, but it's needed for architectures where
> the user range is adjacent to the kernel range (i.e. not x86_64).
I'm unable to trigger the BUG I had with my initramfs with this patch
applied. Thanks!
--
\o/ Arthur
G Gandi.net
next prev parent reply other threads:[~2019-02-18 21:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 23:59 baloo
2019-02-16 4:20 ` Jann Horn
2019-02-16 20:18 ` Thomas Gleixner
2019-02-16 22:25 ` Thomas Gleixner
2019-02-16 22:50 ` Andy Lutomirski
2019-02-16 22:57 ` Andy Lutomirski
2019-02-16 23:47 ` Al Viro
2019-02-17 0:02 ` Al Viro
2019-02-17 2:36 ` Andy Lutomirski
2019-02-17 3:41 ` Arthur Gautier
2019-02-17 4:22 ` Al Viro
2019-02-18 13:04 ` Thomas Gleixner
2019-02-18 19:15 ` Andy Lutomirski
2019-02-18 21:13 ` Jann Horn
2019-02-18 21:51 ` Arthur Gautier [this message]
2019-09-26 9:58 ` Arthur Gautier
2019-09-26 14:09 ` Borislav Petkov
2019-10-10 16:49 ` Arthur Gautier
2019-11-05 14:11 ` Borislav Petkov
2019-11-05 16:05 ` Arthur Gautier
2019-11-06 0:21 ` Andy Lutomirski
2019-11-06 2:22 ` Arthur Gautier
2019-09-26 14:08 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218215150.xklqbfckwmbtdm3t@khany \
--to=baloo@gandi.net \
--cc=bp@alien8.de \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=pascal@gandi.net \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®