From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B69C43381 for ; Tue, 19 Feb 2019 17:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0139B20838 for ; Tue, 19 Feb 2019 17:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727272AbfBSRpz (ORCPT ); Tue, 19 Feb 2019 12:45:55 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34724 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726425AbfBSRpz (ORCPT ); Tue, 19 Feb 2019 12:45:55 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1JHhis9070921 for ; Tue, 19 Feb 2019 12:45:53 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qrkhka6jg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 19 Feb 2019 12:45:49 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Feb 2019 17:45:48 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 19 Feb 2019 17:45:46 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x1JHjjJX48562362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Feb 2019 17:45:45 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 08184AE055; Tue, 19 Feb 2019 17:45:45 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A251CAE045; Tue, 19 Feb 2019 17:45:44 +0000 (GMT) Received: from oc2783563651 (unknown [9.152.97.246]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 19 Feb 2019 17:45:44 +0000 (GMT) Date: Tue, 19 Feb 2019 18:45:43 +0100 From: Halil Pasic To: Pierre Morel Cc: borntraeger@de.ibm.com, cohuck@redhat.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, david@redhat.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, freude@linux.ibm.com Subject: Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem In-Reply-To: <1550513328-12646-2-git-send-email-pmorel@linux.ibm.com> References: <1550513328-12646-1-git-send-email-pmorel@linux.ibm.com> <1550513328-12646-2-git-send-email-pmorel@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19021917-0020-0000-0000-00000318B649 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19021917-0021-0000-0000-00002169FDB7 Message-Id: <20190219184543.25391a2b@oc2783563651> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-19_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902190129 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Feb 2019 19:08:48 +0100 Pierre Morel wrote: > Libudev relies on having a subsystem link for non-root devices. To > avoid libudev (and potentially other userspace tools) choking on the > matrix device let us introduce a vfio_ap bus and with that the vfio_ap > bus subsytem, and make the matrix device reside within it. > > Doing this we need to suppress the forced link from the matrix device to > the vfio_ap driver and we suppress the device_type we do not need > anymore. > > Since the associated matrix driver is not the vfio_ap driver any more, > we have to change the search for the devices on the vfio_ap driver in > the function vfio_ap_verify_queue_reserved. > > Reported-by: Marc Hartmayer > Reported-by: Christian Borntraeger > Signed-off-by: Pierre Morel > --- > drivers/s390/crypto/vfio_ap_drv.c | 48 +++++++++++++++++++++++++++++------ > drivers/s390/crypto/vfio_ap_ops.c | 4 +-- > drivers/s390/crypto/vfio_ap_private.h | 1 + > 3 files changed, 43 insertions(+), 10 deletions(-) > > diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c > index 31c6c84..8e45559 100644 > --- a/drivers/s390/crypto/vfio_ap_drv.c > +++ b/drivers/s390/crypto/vfio_ap_drv.c > @@ -24,10 +24,6 @@ MODULE_LICENSE("GPL v2"); > > static struct ap_driver vfio_ap_drv; > > -static struct device_type vfio_ap_dev_type = { > - .name = VFIO_AP_DEV_TYPE_NAME, > -}; > - Would have been nice had you mentioned this in the commit message -- vfio_ap_dev_type was useless. And you should have removed the define of VFIO_AP_DEV_TYPE_NAME a couple of lines above this. > struct ap_matrix_dev *matrix_dev; > > /* Only type 10 adapters (CEX4 and later) are supported > @@ -62,6 +58,27 @@ static void vfio_ap_matrix_dev_release(struct device *dev) > kfree(matrix_dev); > } > > +static int matrix_bus_match(struct device *dev, struct device_driver *drv) > +{ > + return 1; > +} > + > +static struct bus_type matrix_bus = { > + .name = "vfio_ap", > + .match = &matrix_bus_match, > +}; > + > +static int matrix_probe(struct device *dev) > +{ > + return 0; > +} > + > +static struct device_driver matrix_driver = { > + .name = "vfio_ap", > + .bus = &matrix_bus, > + .probe = matrix_probe, > +}; > + With the changes suggested by Christian: Acked-by: Halil Pasic [..]