From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0ECC43381 for ; Wed, 20 Feb 2019 08:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D2A6208E4 for ; Wed, 20 Feb 2019 08:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NW0gGVek" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbfBTI7y (ORCPT ); Wed, 20 Feb 2019 03:59:54 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34152 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbfBTI7x (ORCPT ); Wed, 20 Feb 2019 03:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CjKmjPfJ4deNl/Uc5pnYReNXv8ZpR/lmREuriH2mTXA=; b=NW0gGVekTZYz+CaI6KxBF1awP AuzILpqn3DVOhgLgUpIY618lcgB/qIlHJfWOs04ZA7PMGe2Zh3W1JROTjpOMUqpDYL+4S6s7TNFU6 a4pd/v/A5VREEpt3CnolKw4maoJTH1/2ZComMveu0BrNGhwNBWVuGk6ns2erjhUh19ltoZ9K8m8rt zmsSl8M2xDvJr6ipcJ5Qg7MAB57/hdcXs4o4bdx+xLXUQFUocQpzZTO3IqSweYTS5Rai3WyyZdqqD QrGKQU8o8S8z9wUPrQxDe/RizwxLhEV63KTvBiLjYvGgI1fhjsq88EUusN9b9lJ2qtxxOQomwrNCn cNgjsroMQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwNjJ-0000XQ-CH; Wed, 20 Feb 2019 08:59:49 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 59B5F202BC402; Wed, 20 Feb 2019 09:59:47 +0100 (CET) Date: Wed, 20 Feb 2019 09:59:47 +0100 From: Peter Zijlstra To: Olof Johansson Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/nmi: ratelimit unknown nmi logs Message-ID: <20190220085947.GA17969@hirez.programming.kicks-ass.net> References: <20190220014836.20510-1-olof@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220014836.20510-1-olof@lixom.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 05:48:36PM -0800, Olof Johansson wrote: > Getting notified of unknown NMIs is obviously important, but getting > notified on every single one, especially on larger systems with slow > (serial) console causes more harm than good when it's a known noisy > non-relevant event. > > So, let's ratelimit to avoid locking up the system. What kind of bonghit broken crap system is that? That is; this _really_ should not happen, and this is a bandaid, not fixing the cause.