From: Nikolaus Voss <nv@vosn.de>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
nikolaus.voss@loewensteinmedical.de
Subject: [PATCH] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters
Date: Mon, 10 Sep 2018 07:05:01 +0200 [thread overview]
Message-ID: <20190220110017.BFA344CE86@mail.steuer-voss.de> (raw)
In-Reply-To: <20180425142209.30745-1-heikki.krogerus@linux.intel.com>
Commit 1a2f474d328f handles block _reads_ separately with plain-I2C
adapters, but the problem described with regmap-i2c not handling
SMBus block transfers (i.e. read and writes) correctly also exists
with writes.
As workaround, this patch adds a block write function the same way
1a2f474d328f adds a block read function.
Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters")
Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
---
drivers/usb/typec/tps6598x.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index c84c8c189e90..57a3e6c5c175 100644
--- a/drivers/usb/typec/tps6598x.c
+++ b/drivers/usb/typec/tps6598x.c
@@ -110,6 +110,20 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
return 0;
}
+static int tps6598x_block_write(struct tps6598x *tps, u8 reg,
+ void *val, size_t len)
+{
+ u8 data[len + 1];
+
+ if (!tps->i2c_protocol)
+ return regmap_raw_write(tps->regmap, reg, val, len);
+
+ data[0] = len;
+ memcpy(&data[1], val, len);
+
+ return regmap_raw_write(tps->regmap, reg, data, sizeof(data));
+}
+
static inline int tps6598x_read16(struct tps6598x *tps, u8 reg, u16 *val)
{
return tps6598x_block_read(tps, reg, val, sizeof(u16));
@@ -127,23 +141,23 @@ static inline int tps6598x_read64(struct tps6598x *tps, u8 reg, u64 *val)
static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
{
- return regmap_raw_write(tps->regmap, reg, &val, sizeof(u16));
+ return tps6598x_block_write(tps, reg, &val, sizeof(u16));
}
static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
{
- return regmap_raw_write(tps->regmap, reg, &val, sizeof(u32));
+ return tps6598x_block_write(tps, reg, &val, sizeof(u32));
}
static inline int tps6598x_write64(struct tps6598x *tps, u8 reg, u64 val)
{
- return regmap_raw_write(tps->regmap, reg, &val, sizeof(u64));
+ return tps6598x_block_write(tps, reg, &val, sizeof(u64));
}
static inline int
tps6598x_write_4cc(struct tps6598x *tps, u8 reg, const char *val)
{
- return regmap_raw_write(tps->regmap, reg, &val, sizeof(u32));
+ return tps6598x_block_write(tps, reg, &val, sizeof(u32));
}
static int tps6598x_read_partner_identity(struct tps6598x *tps)
--
2.17.1
next parent reply other threads:[~2019-02-20 11:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180425142209.30745-1-heikki.krogerus@linux.intel.com>
2018-09-10 5:05 ` Nikolaus Voss [this message]
2019-02-20 12:14 ` Heikki Krogerus
2019-02-20 12:56 ` Nikolaus Voss
2019-02-20 12:57 ` [PATCHv2] " Nikolaus Voss
2019-02-20 13:30 ` Heikki Krogerus
2019-02-20 13:38 ` Nikolaus Voss
2019-02-20 14:14 ` Heikki Krogerus
2019-02-20 14:30 ` Heikki Krogerus
2019-02-20 15:08 ` Nikolaus Voss
2019-02-20 14:45 ` Guenter Roeck
2019-02-20 15:18 ` Nikolaus Voss
2019-02-20 15:02 ` Greg Kroah-Hartman
2019-02-20 15:22 ` Nikolaus Voss
2019-02-20 16:22 ` Greg Kroah-Hartman
2019-02-21 8:37 ` Nikolaus Voss
2019-02-21 9:52 ` Greg Kroah-Hartman
2019-02-21 10:40 ` kbuild test robot
2019-02-20 15:11 ` [PATCHv3] " Nikolaus Voss
2019-02-20 15:35 ` Guenter Roeck
2019-02-20 15:36 ` Guenter Roeck
2019-02-21 8:41 ` Nikolaus Voss
2019-02-21 9:08 ` Heikki Krogerus
2019-02-21 9:42 ` Nikolaus Voss
2019-02-21 9:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220110017.BFA344CE86@mail.steuer-voss.de \
--to=nv@vosn.de \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nikolaus.voss@loewensteinmedical.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®