From: Andrew Morton <akpm@linux-foundation.org>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: "yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"cpandya@codeaurora.org" <cpandya@codeaurora.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] mm: fix set but not used warning
Date: Wed, 20 Feb 2019 13:43:45 -0800 [thread overview]
Message-ID: <20190220134345.e39094996c111be4ffa0c976@linux-foundation.org> (raw)
In-Reply-To: <7425c8905127ddd078500d4c14a2147bd00422a0.camel@hpe.com>
On Tue, 19 Feb 2019 18:28:30 +0000 "Kani, Toshi" <toshi.kani@hpe.com> wrote:
> On Mon, 2019-02-18 at 13:57 +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > lib/ioremap.c: In function 'ioremap_page_range':
> > lib/ioremap.c:203:16: warning:
> > variable 'start' set but not used [-Wunused-but-set-variable]
> >
> > flush_cache_vmap may no need param, so add __maybe_unused fix this warning.
>
> I think flush_cache_vmap should have a proper prototype with
> __maybe_unused for its args. But, there are so many arch-specific
> definitions at glace, and I am not sure how manageable such change is,
> though...
This is one of the reasons why things like flush_cache_vmap() should
be implemented as static inline C functions, not as macros.
prev parent reply other threads:[~2019-02-20 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 13:57 YueHaibing
2019-02-19 18:28 ` Kani, Toshi
2019-02-20 21:43 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220134345.e39094996c111be4ffa0c976@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cpandya@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=will.deacon@arm.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®