mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Pass caller information to log_store().
Date: Thu, 21 Feb 2019 11:22:57 +0900	[thread overview]
Message-ID: <20190221022257.GA15012@jagdpanzerIV> (raw)
In-Reply-To: <1550314773-8607-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On (02/16/19 19:59), Tetsuo Handa wrote:
>  /* insert record into the buffer, discard old ones, update heads */
> -static int log_store(int facility, int level,
> +static int log_store(u32 caller_id, int facility, int level,
>  		     enum log_flags flags, u64 ts_nsec,
>  		     const char *dict, u16 dict_len,
>  		     const char *text, u16 text_len)

I counted nine.

Dunno, we might want to just create a dummy struct and pass it
around, instead of doing

	vprintk_emit			(6 params)
	 vprintk_store			(6 params)
	  log_output			(7 params)
	   log_store			(9 params)

	-ss

  parent reply	other threads:[~2019-02-21  2:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 10:59 Tetsuo Handa
2019-02-20 12:18 ` Petr Mladek
2019-02-21  2:23   ` Sergey Senozhatsky
2019-02-21 11:53     ` Petr Mladek
2019-02-21  2:22 ` Sergey Senozhatsky [this message]
2019-02-21  9:32   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190221022257.GA15012@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®