From: Lukas Wunner <lukas@wunner.de>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: bhelgaas@google.com, austin_bolen@dell.com,
alex_gagniuc@dellteam.com, keith.busch@intel.com,
Shyam_Iyer@Dell.com, okaya@kernel.org, linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Oza Pawandeep <poza@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/4] PCI: hotplug: Add support for disabling in-band presence
Date: Thu, 21 Feb 2019 08:19:46 +0100 [thread overview]
Message-ID: <20190221071946.poqwdilfijpafhvb@wunner.de> (raw)
In-Reply-To: <20190220012031.10741-2-mr.nuke.me@gmail.com>
On Tue, Feb 19, 2019 at 07:20:27PM -0600, Alexandru Gagniuc wrote:
> @@ -846,6 +846,9 @@ struct controller *pcie_init(struct pcie_device *dev)
> if (pdev->is_thunderbolt)
> slot_cap |= PCI_EXP_SLTCAP_NCCS;
>
> + if (pdev->no_in_band_presence)
> + ctrl->inband_presence_disabled = 1;
> +
> ctrl->slot_cap = slot_cap;
> mutex_init(&ctrl->ctrl_lock);
> mutex_init(&ctrl->state_lock);
The above hunk belongs in patch 4.
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -413,6 +413,7 @@ struct pci_dev {
> unsigned int non_compliant_bars:1; /* Broken BARs; ignore them */
> unsigned int is_probed:1; /* Device probing in progress */
> unsigned int link_active_reporting:1;/* Device capable of reporting link active */
> + unsigned int no_in_band_presence:1; /* Device does not report in-band presence */
> unsigned int no_vf_scan:1; /* Don't scan for VFs after IOV enablement */
> pci_dev_flags_t dev_flags;
> atomic_t enable_cnt; /* pci_enable_device has been called */
Same here.
Thanks,
Lukas
next prev parent reply other threads:[~2019-02-21 7:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190220012031.10741-1-mr.nuke.me@gmail.com>
2019-02-20 1:20 ` Alexandru Gagniuc
2019-02-21 7:19 ` Lukas Wunner [this message]
2019-02-21 18:05 ` Alex_Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 2/4] PCI: pciehp: Do not turn off slot if presence comes up after link Alexandru Gagniuc
2019-02-21 7:36 ` Lukas Wunner
2019-02-22 19:56 ` Alex_Gagniuc
2019-02-23 6:49 ` Lukas Wunner
2019-02-24 22:27 ` Alex_Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 3/4] PCI: hotplug: Wait for PDS when in-band presence is disabled Alexandru Gagniuc
2019-02-20 1:20 ` [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches Alexandru Gagniuc
2019-02-21 7:56 ` Lukas Wunner
2019-02-21 18:35 ` Alex_Gagniuc
2019-02-22 1:20 ` Joe Perches
2019-02-22 2:04 ` Oliver
2019-02-22 19:19 ` Alex_Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221071946.poqwdilfijpafhvb@wunner.de \
--to=lukas@wunner.de \
--cc=Shyam_Iyer@Dell.com \
--cc=alex_gagniuc@dellteam.com \
--cc=andy.shevchenko@gmail.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@kernel.org \
--cc=poza@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®