From: Mark Brown <broonie@kernel.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Evan Green <evgreen@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v1] regulator: core: Log forbidden DRMS operation
Date: Thu, 21 Feb 2019 10:12:38 +0000 [thread overview]
Message-ID: <20190221101238.GB5970@sirena.org.uk> (raw)
In-Reply-To: <5ad87a46-147f-0619-29b9-bd352810ade8@free.fr>
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
On Thu, Feb 21, 2019 at 10:42:01AM +0100, Marc Gonzalez wrote:
> On 19/02/2019 17:39, Mark Brown wrote:
> > On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote:
> > No, it's perfectly normal for machine constraints to stop drivers from
> > doing things so we shouldn't warn on this - it would get incredibly
> > noisy if we started printing every time constraints didn't let us do
> > something at info level. Debug level might be viable, or definitely
> > vdbg or trace points.
> Several functions return an error (and log a KERN_ERR message) if their
> corresponding flag is not set:
>
> regulator_check_voltage() REGULATOR_CHANGE_VOLTAGE
That's a bug due to an incomplete implementation, what it's supposed to
be doing there is checking if the voltage request is satisfied by the
current voltage and returning an error only if the requested voltage is
out of range.
> regulator_check_current_limit() REGULATOR_CHANGE_CURRENT
This one is less clear than anything else - we might want to error out
here if the device is somehow relying on being able to lower the current
limit for safety. We'd need an audit of users.
> regulator_mode_constrain() REGULATOR_CHANGE_MODE
This one is also a bug, modes barely mean anything anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-21 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:02 Marc Gonzalez
2019-02-19 16:39 ` Mark Brown
2019-02-21 9:37 ` Marc Gonzalez
2019-02-21 9:42 ` Marc Gonzalez
2019-02-21 10:12 ` Mark Brown [this message]
2019-02-21 11:55 ` [PATCH v2] " Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221101238.GB5970@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®