From: Dave Martin <Dave.Martin@arm.com>
To: Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kristina Martsenko <kristina.martsenko@arm.com>,
kvmarm@lists.cs.columbia.edu,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/6] arm64/kvm: control accessibility of ptrauth key registers
Date: Thu, 21 Feb 2019 15:53:59 +0000 [thread overview]
Message-ID: <20190221155359.GZ3567@e103592.cambridge.arm.com> (raw)
In-Reply-To: <1550568271-5319-6-git-send-email-amit.kachhap@arm.com>
On Tue, Feb 19, 2019 at 02:54:30PM +0530, Amit Daniel Kachhap wrote:
> According to userspace settings, ptrauth key registers are conditionally
> present in guest system register list based on user specified flag
> KVM_ARM_VCPU_PTRAUTH.
>
> Reset routines still sets these registers to default values but they are
> left like that as they are conditionally accessible (set/get).
>
> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Christoffer Dall <christoffer.dall@arm.com>
> Cc: kvmarm@lists.cs.columbia.edu
> ---
> This patch needs patch [1] by Dave Martin and adds feature to manage accessibility in a scalable way.
>
> [1]: https://lore.kernel.org/linux-arm-kernel/1547757219-19439-13-git-send-email-Dave.Martin@arm.com/
FYI, check_present() has changed a bit in the SVE v5 series [2].
The precise interface is still under discussion, so please take a look
and feel free to comment.
You'll probably need to tweak some things so that the KVM_GET_REG_LIST
output is consistent with the set of regs that do/don't yield -ENOENT in
KVM_GET_ONE_REG/KVM_SET_ONE_REG.
See other patches in the series for examples of how I use the modified
interface.
[...]
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index f7bcc60..c2f4974 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -1005,8 +1005,13 @@ static bool trap_ptrauth(struct kvm_vcpu *vcpu,
> return false;
> }
>
> +static bool check_ptrauth(const struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd)
> +{
> + return kvm_arm_vcpu_ptrauth_allowed(vcpu);
> +}
> +
> #define __PTRAUTH_KEY(k) \
> - { SYS_DESC(SYS_## k), trap_ptrauth, reset_unknown, k }
> + { SYS_DESC(SYS_## k), trap_ptrauth, reset_unknown, k , .check_present = check_ptrauth}
Cheers
---Dave
[2] [PATCH v5 12/26] KVM: arm64: Support runtime sysreg visibility filtering
https://lists.cs.columbia.edu/pipermail/kvmarm/2019-February/034671.html
next prev parent reply other threads:[~2019-02-21 15:54 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 9:24 [PATCH v6 0/6] Add ARMv8.3 pointer authentication for kvm guest Amit Daniel Kachhap
2019-02-19 9:24 ` [PATCH v6 1/6] arm64/kvm: preserve host HCR_EL2 value Amit Daniel Kachhap
2019-02-21 11:50 ` Mark Rutland
2019-02-25 18:09 ` Marc Zyngier
2019-02-28 6:43 ` Amit Daniel Kachhap
2019-02-21 15:49 ` Dave Martin
2019-03-01 5:56 ` Amit Daniel Kachhap
2019-02-25 17:39 ` James Morse
2019-02-26 10:06 ` James Morse
2019-03-02 11:09 ` Amit Daniel Kachhap
2019-02-19 9:24 ` [PATCH v6 2/6] arm64/kvm: preserve host MDCR_EL2 value Amit Daniel Kachhap
2019-02-21 11:57 ` Mark Rutland
2019-02-21 15:51 ` Dave Martin
2019-03-01 6:10 ` Amit Daniel Kachhap
2019-02-19 9:24 ` [PATCH v6 3/6] arm64/kvm: context-switch ptrauth registers Amit Daniel Kachhap
2019-02-21 12:29 ` Mark Rutland
2019-02-21 15:51 ` Dave Martin
2019-03-01 6:17 ` Amit Daniel Kachhap
2019-02-28 9:07 ` Amit Daniel Kachhap
2019-02-21 15:53 ` Dave Martin
2019-03-01 9:35 ` Amit Daniel Kachhap
2019-02-26 18:31 ` James Morse
2019-03-04 10:51 ` Amit Daniel Kachhap
2019-02-19 9:24 ` [PATCH v6 4/6] arm64/kvm: add a userspace option to enable pointer authentication Amit Daniel Kachhap
2019-02-21 12:34 ` Mark Rutland
2019-02-28 9:25 ` Amit Daniel Kachhap
2019-02-21 15:53 ` Dave Martin
2019-03-01 9:41 ` Amit Daniel Kachhap
2019-03-01 12:22 ` Dave P Martin
2019-02-26 18:33 ` James Morse
2019-03-04 10:56 ` Amit Daniel Kachhap
2019-02-19 9:24 ` [PATCH v6 5/6] arm64/kvm: control accessibility of ptrauth key registers Amit Daniel Kachhap
2019-02-21 15:53 ` Dave Martin [this message]
2019-02-26 18:34 ` James Morse
2019-02-19 9:24 ` [kvmtool PATCH v6 6/6] arm/kvm: arm64: Add a vcpu feature for pointer authentication Amit Daniel Kachhap
2019-02-21 15:54 ` Dave Martin
2019-03-01 10:37 ` Amit Daniel Kachhap
2019-03-01 11:24 ` Dave P Martin
2019-03-04 11:08 ` Amit Daniel Kachhap
2019-03-05 11:11 ` Dave Martin
2019-02-26 18:03 ` [PATCH v6 0/6] Add ARMv8.3 pointer authentication for kvm guest James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221155359.GZ3567@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®