From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A0EAC4360F for ; Thu, 21 Feb 2019 20:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B9BC20836 for ; Thu, 21 Feb 2019 20:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbfBUUpR (ORCPT ); Thu, 21 Feb 2019 15:45:17 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:35095 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfBUUpQ (ORCPT ); Thu, 21 Feb 2019 15:45:16 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gwvDM-0007v6-NV; Thu, 21 Feb 2019 21:45:04 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1gwvDM-0005Bi-1H; Thu, 21 Feb 2019 21:45:04 +0100 Date: Thu, 21 Feb 2019 21:45:04 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Claudiu.Beznea@microchip.com Cc: thierry.reding@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] pwm: atmel: add support for SAM9X60's PWM controller Message-ID: <20190221204503.w2xh4rw6rh4e5rg4@pengutronix.de> References: <1550570914-26391-1-git-send-email-claudiu.beznea@microchip.com> <1550570914-26391-4-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1550570914-26391-4-git-send-email-claudiu.beznea@microchip.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 10:09:00AM +0000, Claudiu.Beznea@microchip.com wrote: > From: Claudiu Beznea > > Add support for SAM9X60's PWM controller. > > Signed-off-by: Claudiu Beznea > --- > drivers/pwm/pwm-atmel.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c > index 647d063562db..229cedb02770 100644 > --- a/drivers/pwm/pwm-atmel.c > +++ b/drivers/pwm/pwm-atmel.c > @@ -52,6 +52,8 @@ > > /* Only the LSB 16 bits are significant. */ > #define PWM_MAXV1_PRD 0xFFFF > +/* All 32 bits are significant. */ > +#define PWM_MAXV2_PRD 0xFFFFFFFF > #define PRD_MAXV1_PRES 10 > > struct atmel_pwm_registers { > @@ -311,6 +313,20 @@ static const struct atmel_pwm_data atmel_pwm_data_v2 = { > }, > }; > > +static const struct atmel_pwm_data atmel_pwm_data_v3 = { Does it make more sense to call this ..._sam9x60 to match the compatible? (If yes, patch 1 should be changed accordingly.) I wonder how the naming of the defines is chosen given that pwm_data_v3 is the first that needs PWM_MAXV2_PRD. Looks inconsistent. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |