From: Marc Zyngier <marc.zyngier@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Christoffer Dall <christoffer.dall@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Jun Yao <yaojun8558363@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] KVM: arm/arm64: vgic: Improve comment on kvm_vgic_inject_irq
Date: Fri, 22 Feb 2019 08:37:56 +0000 [thread overview]
Message-ID: <20190222083756.359523ca@why.wild-wind.fr.eu.org> (raw)
In-Reply-To: <20190222082327.3312-3-leo.yan@linaro.org>
On Fri, 22 Feb 2019 16:23:24 +0800
Leo Yan <leo.yan@linaro.org> wrote:
> The function kvm_vgic_inject_irq() is not only used by PPIs but also can
> be used to inject interrupt for SPIs; this patch improves comment for
> argument @cpuid to reflect support SPIs as well.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> virt/kvm/arm/vgic/vgic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic.c b/virt/kvm/arm/vgic/vgic.c
> index 7cfdfbc910e0..79fe64c15051 100644
> --- a/virt/kvm/arm/vgic/vgic.c
> +++ b/virt/kvm/arm/vgic/vgic.c
> @@ -394,7 +394,7 @@ bool vgic_queue_irq_unlock(struct kvm *kvm, struct vgic_irq *irq,
> /**
> * kvm_vgic_inject_irq - Inject an IRQ from a device to the vgic
> * @kvm: The VM structure pointer
> - * @cpuid: The CPU for PPIs
> + * @cpuid: The CPU for PPIs and SPIs
> * @intid: The INTID to inject a new state to.
> * @level: Edge-triggered: true: to trigger the interrupt
> * false: to ignore the call
What does the CPU mean for SPIs? By definition, the routing of an SPI
is defined by the distributor configuration. And what about LPIs? SGIs?
I'm afraid you've misunderstood what cpuid is for.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2019-02-22 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 8:23 [PATCH v1 0/4] ARM64/KVM: Minor cleanup and refactoring Leo Yan
2019-02-22 8:23 ` [PATCH v1 1/4] KVM: arm64: Use macro to replace hard number Leo Yan
2019-02-22 11:40 ` Mark Rutland
2019-02-22 8:23 ` [PATCH v1 2/4] KVM: arm/arm64: vgic: Improve comment on kvm_vgic_inject_irq Leo Yan
2019-02-22 8:37 ` Marc Zyngier [this message]
2019-02-22 8:54 ` Leo Yan
2019-02-22 9:39 ` Marc Zyngier
2019-02-22 12:49 ` Leo Yan
2019-02-22 15:40 ` Marc Zyngier
2019-02-25 0:09 ` Leo Yan
2019-02-22 8:23 ` [PATCH v1 3/4] KVM: arm/arm64: Define TCR_EL2_T0SZ_MASK as TCR_T0SZ_MASK Leo Yan
2019-02-22 11:43 ` Mark Rutland
2019-02-22 8:23 ` [PATCH v1 4/4] KVM: arm/arm64: Fix comment on create_hyp_mappings() Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222083756.359523ca@why.wild-wind.fr.eu.org \
--to=marc.zyngier@arm.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pbonzini@redhat.com \
--cc=will.deacon@arm.com \
--cc=yaojun8558363@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®