From: Jonathan Corbet <corbet@lwn.net>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] docs: Explicitly state that the 'Fixes:' tag shouldn't split lines
Date: Fri, 22 Feb 2019 08:56:37 -0700 [thread overview]
Message-ID: <20190222085637.39f02baa@lwn.net> (raw)
In-Reply-To: <20190219152715.5674-1-sean.j.christopherson@intel.com>
On Tue, 19 Feb 2019 07:27:15 -0800
Sean Christopherson <sean.j.christopherson@intel.com> wrote:
> ...and use a commit with an obnoxiously long summary in the example to
> make it abundantly clear that keeping the tag on a single line takes
> priority over wrapping at 75 columns. Without the explicit exemption,
> one might assume splitting the tag is acceptable, even encouraged, e.g.
> due to being conditioned by checkpatch's line length warning.
>
> Per Stephen's scripts[1] and implied by commit bf4daf12a9fb ("checkpatch:
> avoid some commit message long line warnings"), splitting the 'Fixes:'
> tag across multiple lines is a no-no, presumably because parsing multi-
> line tags is unnecessarily painful.
>
> [1] https://lkml.kernel.org/r/20190216183433.71b7cfa7@canb.auug.org.au
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Applied, thanks.
jon
prev parent reply other threads:[~2019-02-22 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 15:27 Sean Christopherson
2019-02-22 15:56 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222085637.39f02baa@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome