From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA45C43381 for ; Fri, 22 Feb 2019 17:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 876D120700 for ; Fri, 22 Feb 2019 17:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ea99hVu2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727493AbfBVRwH (ORCPT ); Fri, 22 Feb 2019 12:52:07 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:40044 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727370AbfBVRwE (ORCPT ); Fri, 22 Feb 2019 12:52:04 -0500 Received: by mail-lj1-f194.google.com with SMTP id w6so2364482ljd.7; Fri, 22 Feb 2019 09:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/lwl4BC+Dpj5p+ishZ2KB+Xc2f6Kh/Dfoik9g6S5bN4=; b=Ea99hVu2ISsyUFe9CNyHHDgyXpOJqPBEhljtiUa7cENjw+NHh55+Y933fPNCoyLo4l u5gparC4djukz8B0rbrUKyG++XqyiuIXcHEl6fYPrR+IhPIt1I7yh3ox77jBkevIgxb4 Hlgm0NBrgaMSgwVaJpwzJj3NGWTbeoaKPDXuqQLahDznse0duuOD2ozt2dVZNKxrmWzT oIrZDtWvoEVn5dINHGHKz56r9yM2jg65tV1TmebzM2LCg7AJ5k0vWai/YpDOXAnygI7M KeP4Ol4FPJhB7E+q1vfuE18NA2vojuHyiHw83Qljf40Qtk6eVDgSLnfuKxutSg+EVwvw mZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/lwl4BC+Dpj5p+ishZ2KB+Xc2f6Kh/Dfoik9g6S5bN4=; b=ZyRVzxNtFaZQ8xOu62v/0VtAyNYeM2MwtObg0+dZDarDRs/qIA0IcF8JUTw97V3dmc s/mDpnrImrhweifIGY2sGCq4HzN7ngrtHBEdH5foMYQKj2EV/IrrzwOjesrAoknm1UCd ObDpVTresiwuNHxjhRrzc2IOwGLiOTLVVKO9+aMm3oDRXgr3raMmiQ9I0SfQa43rakTX Z0EsLzkJd4mU0stb1KZLC+o/1i9TxL7SWxeF1nbmIMJsLzlyWjwxMebujS40VyUrfLt4 vpdgA05k5JzmBx8fL1ie43GLeBPPwleFGtJvQJ3O8gTKNKtuMrunlKJx2inGGwLpC5iB 5T9g== X-Gm-Message-State: AHQUAubN2XigHQEliDWjkOkO6gO2mobzBxFpY1zNo0dIgAT8XTMUK/eq dFdTF1dDxUORFy++2xy1970= X-Google-Smtp-Source: AHgI3IaWx//Gx6nghmkwEVCvzIRzG0loIJWwv3pil94SSt3DSDpUMPaxuLtSxMlKFDwcg+3x2a/CqQ== X-Received: by 2002:a2e:5b44:: with SMTP id p65mr3015722ljb.182.1550857920773; Fri, 22 Feb 2019 09:52:00 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:b16d:ecd7:a81b:d059]) by smtp.googlemail.com with ESMTPSA id v65sm655958lje.77.2019.02.22.09.51.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 09:52:00 -0800 (PST) From: =?UTF-8?q?Pawe=C5=82=20Chmiel?= To: thierry.reding@gmail.com Cc: airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com, m.szyprowski@samsung.com, krzk@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Pawe=C5=82=20Chmiel?= Subject: [PATCH v4 2/2] drm/panel: Add driver for Samsung S6E63M0 panel Date: Fri, 22 Feb 2019 18:51:53 +0100 Message-Id: <20190222175153.20567-2-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190222175153.20567-1-pawel.mikolaj.chmiel@gmail.com> References: <20190222175153.20567-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds Samsung S6E63M0 AMOLED LCD panel driver, connected over spi. It's based on already removed, non dt s6e63m0 driver and panel-samsung-ld9040. It can be found for example in some of Samsung Aries based phones. Signed-off-by: Paweł Chmiel Reviewed-by: Sam Ravnborg Reviewed-by: Andrzej Hajda --- Changes from v3: - Squash s6e63m0_brightness_set into s6e63m0_set_brightness - In power_on assert reset gpio after regulators, like it was done in vendor sources - In power_off assert reset gpio before regulators, like it was done in vendor sources - Add reviewed by - Match MCS command names (taken from other samsung panels) Changes from v2: - VIDEOMODE_HELPERS is not needed in Kconfig - Added help text to Kconfig - Remove unneeded videomode includes/fields - Add sentinel comment in s6e63m0_of_match struct - Handle errors during registration of backlight device. We shouldn't register panel if we fail to register backlight device - Added Reviewed-by Changes from v1: - Correct order of Kconfig/Makefile entry - Fix SPDX tag, so it matches value of MODULE_LICENSE - Remove inclusion of drmP.h - Fix code formatting - Use DRM_DEV_ERROR/DEBUG - Extract hardcoded values - Remove possibility to change gamma through sysfs, leaving only one gamma table values - Fix reset_gpio handling, so it'll be asserted in power_on and deasserted in power_off. Also do it before turning voltage on. - Disable backlight and enter sleep mode in disable callback. Previously it was done in unprepare - Enable display and backlight in enable callback. Previously it was done in prepare - Hardcode display timings and delays. Previously they were readed from device tree - We're using SPDX, so we don't need to have license body - Use MIPI_DCS_EXIT_SLEEP_MODE and MIPI_DCS_SET_DISPLAY_ON - Rename MAX_GAMMA_LEVEL to NUM_GAMMA_LEVELS - Ommit get_brightness callback - Use backlight_enable/disable API, like it's done in other panel drivers (for example panel-simple) - Make set_brightness called only from backlight api, like it's done in other panel drivers (for example panel-simple). - Reset gpio should be set to GPIOD_OUT_HIGH. It's declared as active low in device tree - Don't call power_off in remove callback --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 514 ++++++++++++++++++ 3 files changed, 524 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e63m0.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 3f3537719beb..45e9ab4b7857 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -158,6 +158,15 @@ config DRM_PANEL_SAMSUNG_S6E63J0X03 depends on BACKLIGHT_CLASS_DEVICE select VIDEOMODE_HELPERS +config DRM_PANEL_SAMSUNG_S6E63M0 + tristate "Samsung S6E63M0 RGB/SPI panel" + depends on OF + depends on SPI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for Samsung s6e63m0 + AMOLED LCD panel. + config DRM_PANEL_SAMSUNG_S6E8AA0 tristate "Samsung S6E8AA0 DSI video mode panel" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 4396658a7996..4507a2d253ac 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_DRM_PANEL_SAMSUNG_LD9040) += panel-samsung-ld9040.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6D16D0) += panel-samsung-s6d16d0.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E3HA2) += panel-samsung-s6e3ha2.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E63J0X03) += panel-samsung-s6e63j0x03.o +obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E63M0) += panel-samsung-s6e63m0.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0) += panel-samsung-s6e8aa0.o obj-$(CONFIG_DRM_PANEL_SEIKO_43WVF1G) += panel-seiko-43wvf1g.o obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += panel-sharp-lq101r1sx01.o diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c new file mode 100644 index 000000000000..142d395ea512 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c @@ -0,0 +1,514 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * S6E63M0 AMOLED LCD drm_panel driver. + * + * Copyright (C) 2019 Paweł Chmiel + * Derived from drivers/gpu/drm/panel-samsung-ld9040.c + * + * Andrzej Hajda + */ + +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#include