From: "Bárbara Fernandes" <barbara.fernandes@usp.br>
To: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-usp@googlegroups.com,
"Bárbara Fernandes" <barbara.fernandes@usp.br>
Subject: [PATCH 2/4] iio:adc:ad7923: Use BIT macro instead of bitshift
Date: Fri, 22 Feb 2019 17:31:57 -0300 [thread overview]
Message-ID: <20190222203159.15116-3-barbara.fernandes@usp.br> (raw)
In-Reply-To: <20190222203159.15116-1-barbara.fernandes@usp.br>
Replace use of the operation '<<' by the BIT macro. Solves checkpath.pl's
message:
CHECK: Prefer using the BIT macro
Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
---
drivers/iio/adc/ad7923.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
index ebae7522710a..b39ea834cdd6 100644
--- a/drivers/iio/adc/ad7923.c
+++ b/drivers/iio/adc/ad7923.c
@@ -24,9 +24,9 @@
#include <linux/iio/trigger_consumer.h>
#include <linux/iio/triggered_buffer.h>
-#define AD7923_WRITE_CR (1 << 11) /* write control register */
-#define AD7923_RANGE (1 << 1) /* range to REFin */
-#define AD7923_CODING (1 << 0) /* coding is straight binary */
+#define AD7923_WRITE_CR BIT(11) /* write control register */
+#define AD7923_RANGE BIT(1) /* range to REFin */
+#define AD7923_CODING BIT(0) /* coding is straight binary */
#define AD7923_PM_MODE_AS (1) /* auto shutdown */
#define AD7923_PM_MODE_FS (2) /* full shutdown */
#define AD7923_PM_MODE_OPS (3) /* normal operation */
--
2.17.1
next prev parent reply other threads:[~2019-02-22 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:31 [PATCH 0/4] Solve checkstyle problems Bárbara Fernandes
2019-02-22 20:31 ` [PATCH 1/4] iio:adc:ad7923: Align broken line to parenthesis Bárbara Fernandes
2019-03-03 14:43 ` Jonathan Cameron
2019-02-22 20:31 ` Bárbara Fernandes [this message]
2019-03-03 14:44 ` [PATCH 2/4] iio:adc:ad7923: Use BIT macro instead of bitshift Jonathan Cameron
2019-02-22 20:31 ` [PATCH 3/4] iio:adc:ad7923: Put macro argument between ()'s Bárbara Fernandes
2019-03-03 14:45 ` Jonathan Cameron
2019-02-22 20:31 ` [PATCH 4/4] iio:adc:ad7923: Rewrite comparison to NULL Bárbara Fernandes
2019-03-03 14:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222203159.15116-3-barbara.fernandes@usp.br \
--to=barbara.fernandes@usp.br \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®