mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Shuah Khan <shuah@kernel.org>
Cc: mchehab@kernel.org, hans.verkuil@cisco.com,
	keescook@chromium.org, sakari.ailus@linux.intel.com,
	colin.king@canonical.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] au0828: minor fix to a misleading comment in _close()
Date: Sat, 23 Feb 2019 02:44:22 +0100	[thread overview]
Message-ID: <20190223014422.GS11484@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20190222174559.8084-1-shuah@kernel.org>

Hi Shuah,

Thanks for your patch.

On 2019-02-22 10:45:59 -0700, Shuah Khan wrote:
> Fix misleading comment in _close()
> 
> Signed-off-by: Shuah Khan <shuah@kernel.org>
> ---
>  drivers/media/usb/au0828/au0828-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> index 7876c897cc1d..08f566006a1f 100644
> --- a/drivers/media/usb/au0828/au0828-video.c
> +++ b/drivers/media/usb/au0828/au0828-video.c
> @@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
>  		 * so the s_power callback are silently ignored.
>  		 * So, the current logic here does the following:
>  		 * Disable (put tuner to sleep) when
> -		 * - ALSA and DVB aren't not streaming;
> +		 * - ALSA and DVB aren't streaming;

Nit-picking, as you are modifying the line anyhow I would s/;/./
With or without this changed,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

>  		 * - the last V4L2 file handler is closed.
>  		 *
>  		 * FIXME:
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

  reply	other threads:[~2019-02-23  1:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 17:45 Shuah Khan
2019-02-23  1:44 ` Niklas Söderlund [this message]
2019-02-25 12:35   ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190223014422.GS11484@bigcity.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=colin.king@canonical.com \
    --cc=hans.verkuil@cisco.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®