From: Bharath Vedartham <linux.bhar@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
gregkh@linuxfoundation.org, speakup@linux-speakup.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: Replace simple_strtoul with kstrtoul
Date: Sun, 24 Feb 2019 01:32:20 +0530 [thread overview]
Message-ID: <20190223200220.GA3573@bharath12345-Inspiron-5559> (raw)
In-Reply-To: <20190223193750.2yd3qiyr6q3wx463@function>
On Sat, Feb 23, 2019 at 08:37:50PM +0100, Samuel Thibault wrote:
> Bharath Vedartham, le dim. 24 févr. 2019 01:01:21 +0530, a ecrit:
> > simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building
> > and booting successfully.
>
> Please recheck your patch, temp is used after the simple_strtoul call.
>
> Samuel
Sorry about that. After some thought, I feel this is a special case in
replacing simple_strtoul to kstrtoul. simple_strtoul can give back a
pointer to the end of the parsed string, whereas kstrtoul does not
give any thing of that kind. In our case, temp is the end of the
parsed cp string.
To replace simple_strtoul to kstrtoul, we need to know the length of the
unsigned long int returned and shift the cp pointer by that length to
get temp. This might involve a bit of code refactoring.
Bharath
next prev parent reply other threads:[~2019-02-23 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 19:31 Bharath Vedartham
2019-02-23 19:37 ` Samuel Thibault
2019-02-23 20:02 ` Bharath Vedartham [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-17 11:56 [PATCH] staging: speakup: replace " samuel kihahu
2014-12-17 12:11 ` Dan Carpenter
2014-12-17 13:43 ` samuel kihahu
2014-12-17 14:03 ` Dan Carpenter
2014-12-18 14:48 ` samuel kihahu
2014-12-18 21:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223200220.GA3573@bharath12345-Inspiron-5559 \
--to=linux.bhar@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®