From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184CDC43381 for ; Sat, 23 Feb 2019 21:10:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF9152085A for ; Sat, 23 Feb 2019 21:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550956224; bh=HRz0JT5jcdf+PcR8U9KR4RsXQEcbJoxZp70AgItm/kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vvuwYzMXKzhd4LEr1DWjqAZCfnnaRtoZziz3ysDplJVPFboJhXzWUlE80EKJKWPqh kenz3FwVgjpxFWZxJL8xx7X9hAFL1PMBU9OBpYLBeeounei4ufGTZ851iQJZbusB1u aSn/RQ+uflwEGZeNb9qhM6S29jhBLLMO/e5NMnVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729755AbfBWVKX (ORCPT ); Sat, 23 Feb 2019 16:10:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:46374 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729734AbfBWVKU (ORCPT ); Sat, 23 Feb 2019 16:10:20 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74D2B20855; Sat, 23 Feb 2019 21:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550956220; bh=HRz0JT5jcdf+PcR8U9KR4RsXQEcbJoxZp70AgItm/kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ELirDfBBHrqhvO2pdgVe/c0dQtqOTEeImR49jautp/81Pql101+Xo7eBPliUBS52G bcNQuJPtRGajALd2ZJ+wMF6O8ck7c4j6aUzsKHvCPag9X3vSZcRgc/lPZHKcRkYiPc 8QrNbYsYnBz67D8I7VosMy2lp0+kZFTEQrBudIQg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yonglong Liu , Peng Li , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 17/32] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Date: Sat, 23 Feb 2019 16:09:36 -0500 Message-Id: <20190223210951.202268-17-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190223210951.202268-1-sashal@kernel.org> References: <20190223210951.202268-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yonglong Liu [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 501eb2090ca62..de23a0ead5d76 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -329,7 +329,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum) } hns_mdio_cmd_write(mdio_dev, is_c45, - MDIO_C45_WRITE_ADDR, phy_id, devad); + MDIO_C45_READ, phy_id, devad); } /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/ -- 2.19.1