From: kbuild test robot <lkp@intel.com>
To: Shaobo He <shaobo@cs.utah.edu>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
laurent.pinchart@ideasonboard.com, shaobo@cs.utah.edu,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rick Chang <rick.chang@mediatek.com>,
Bin Liu <bin.liu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>,
Jacob chen <jacob2.chen@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kamil Debski <kamil@wypas.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Benoit Parrot <bparrot@ti.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Anton Leontiev <scileont@gmail.com>,
Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:MEDIA DRIVERS FOR RENESAS - FDP1"
<linux-renesas-soc@vger.kernel.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] Remove deductively redundant NULL pointer checks
Date: Tue, 26 Feb 2019 16:47:53 +0800 [thread overview]
Message-ID: <201902261610.hp3DQi3p%fengguang.wu@intel.com> (raw)
In-Reply-To: <1551128631-19713-1-git-send-email-shaobo@cs.utah.edu>
[-- Attachment #1: Type: text/plain, Size: 4427 bytes --]
Hi Shaobo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.0-rc8 next-20190225]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Shaobo-He/Remove-deductively-redundant-NULL-pointer-checks/20190226-133616
base: git://linuxtv.org/media_tree.git master
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-8 (Debian 8.2.0-20) 8.2.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/media//platform/vim2m.c: In function 'vidioc_s_fmt':
>> drivers/media//platform/vim2m.c:689:6: warning: 'vq' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (vb2_is_busy(vq)) {
^~~~~~~~~~~~~~~
vim +/vq +689 drivers/media//platform/vim2m.c
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 679
1f923a42 drivers/media/platform/vim2m.c Hans Verkuil 2014-09-22 680 static int vidioc_s_fmt(struct vim2m_ctx *ctx, struct v4l2_format *f)
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 681 {
1f923a42 drivers/media/platform/vim2m.c Hans Verkuil 2014-09-22 682 struct vim2m_q_data *q_data;
d80ee38c drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2011-01-12 683 struct vb2_queue *vq;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 684
9f4161a6 drivers/media/video/mem2mem_testdev.c Tomasz Moń 2012-06-08 685 q_data = get_q_data(ctx, f->type);
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 686 if (!q_data)
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 687 return -EINVAL;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 688
d80ee38c drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2011-01-12 @689 if (vb2_is_busy(vq)) {
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 690 v4l2_err(&ctx->dev->v4l2_dev, "%s queue busy\n", __func__);
07e80305 drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2010-12-20 691 return -EBUSY;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 692 }
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 693
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 694 q_data->fmt = find_format(f);
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 695 q_data->width = f->fmt.pix.width;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 696 q_data->height = f->fmt.pix.height;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 697 q_data->sizeimage = q_data->width * q_data->height
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 698 * q_data->fmt->depth >> 3;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 699
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 700 dprintk(ctx->dev,
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 701 "Setting format for type %d, wxh: %dx%d, fmt: %d\n",
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 702 f->type, q_data->width, q_data->height, q_data->fmt->fourcc);
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 703
07e80305 drivers/media/video/mem2mem_testdev.c Marek Szyprowski 2010-12-20 704 return 0;
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 705 }
96d8eab5 drivers/media/video/mem2mem_testdev.c Pawel Osciak 2010-04-23 706
:::::: The code at line 689 was first introduced by commit
:::::: d80ee38cd845baadef175893b99df24e7a03ec40 [media] v4l: mem2mem: port m2m_testdev to vb2
:::::: TO: Marek Szyprowski <m.szyprowski@samsung.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66463 bytes --]
next prev parent reply other threads:[~2019-02-26 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 21:03 Shaobo He
2019-02-26 8:00 ` kbuild test robot
2019-02-26 8:47 ` kbuild test robot [this message]
2019-02-27 0:43 Shaobo He
2019-03-03 23:34 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201902261610.hp3DQi3p%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=a.hajda@samsung.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=andrzej.p@samsung.com \
--cc=bin.liu@mediatek.com \
--cc=bparrot@ti.com \
--cc=ezequiel@collabora.com \
--cc=gustavo@embeddedor.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=jacob2.chen@rock-chips.com \
--cc=kamil@wypas.org \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mikhail.ulyanov@cogentembedded.com \
--cc=p.zabel@pengutronix.de \
--cc=rick.chang@mediatek.com \
--cc=sakari.ailus@linux.intel.com \
--cc=scileont@gmail.com \
--cc=shaobo@cs.utah.edu \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®