From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <longman@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH-tip v2 00/10] locking/rwsem: Rwsem rearchitecture part 1
Date: Tue, 26 Feb 2019 10:20:13 -0800 [thread overview]
Message-ID: <20190226182013.iynflounqufjtnli@linux-r8p5> (raw)
In-Reply-To: <1550263810-31947-1-git-send-email-longman@redhat.com>
On Fri, 15 Feb 2019, Waiman Long wrote:
> v2:
> - Sync up to v4 of the part 0 patch.
> - Remove the rwsem.h->rwsem-xadd.h renaming patch & change patches
> to modify rwsem.h instead of rwsem-xadd.h.
> - Add a new patch to micro-optimize rwsem_try_read_lock_unqueued().
>
>This is part 1 of a 3-part (0/1/2) series to rearchitect the internal
>operation of rwsem. This depends on the v4 part 0 patches sent out
>previously
>
>https://lore.kernel.org/lkml/1550095217-12047-1-git-send-email-longman@redhat.com
>
>This part lays the foundation for part 2 without making any functional
>changes. This part includes the following changes:
>
> 1) Move code around and micro-optimize rwsem_try_read_lock_unqueued()
> (patches 1-4).
> 2) Enhance the DEBUG_RWSEMS_WARN_ON() macro to provide more information
> and add additional checks (patches 5 & 6).
> 3) Make the core qspinlock_stat.h code generic (lock event counting)
> so that it can be used by all the architectures as well as other
> locking subsystems such as rwsem (patches 7-10). Lock event
> counting help us visualize how frequently a code path is being
> used as well as spotting abnormal behavior due to bugs in the code
> without noticeably affecting kernel performance and hence behavior.
>
>Both (2) and (3) are useful debugging aids.
Yes, this will come in handy in the future. Feel free to add my:
Acked-by: Davidlohr Bueso <dbueso@suse.de>
Thanks.
prev parent reply other threads:[~2019-02-26 18:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 20:50 Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 01/10] locking/rwsem: Relocate rwsem_down_read_failed() Waiman Long
2019-02-21 14:14 ` Will Deacon
2019-02-15 20:50 ` [PATCH-tip v2 02/10] locking/rwsem: Move owner setting code from rwsem.c to rwsem.h Waiman Long
2019-02-21 14:15 ` Will Deacon
2019-02-22 3:37 ` Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 03/10] locking/rwsem: Move rwsem internal function declarations to rwsem-xadd.h Waiman Long
2019-02-21 14:15 ` Will Deacon
2019-02-15 20:50 ` [PATCH-tip v2 04/10] locking/rwsem: Micro-optimize rwsem_try_read_lock_unqueued() Waiman Long
2019-02-21 14:15 ` Will Deacon
2019-02-15 20:50 ` [PATCH-tip v2 05/10] locking/rwsem: Add debug check for __down_read*() Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 06/10] locking/rwsem: Enhance DEBUG_RWSEMS_WARN_ON() macro Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 07/10] locking/qspinlock_stat: Introduce a generic lockevent counting APIs Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 08/10] locking/lock_events: Make lock_events available for all archs & other locks Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 09/10] locking/lock_events: Don't show pvqspinlock events on bare metal Waiman Long
2019-02-15 20:50 ` [PATCH-tip v2 10/10] locking/rwsem: Enable lock event counting Waiman Long
2019-02-26 18:20 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226182013.iynflounqufjtnli@linux-r8p5 \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®