From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, idosch@mellanox.com,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
bridge@lists.linux-foundation.org, jiri@mellanox.com,
andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [PATCH net-next v3 0/8] net: Remove switchdev_ops
Date: Wed, 27 Feb 2019 12:40:19 -0800 (PST) [thread overview]
Message-ID: <20190227.124019.281722845670775310.davem@davemloft.net> (raw)
In-Reply-To: <20190227194432.725-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 27 Feb 2019 11:44:24 -0800
> This patch series completes the removal of the switchdev_ops by
> converting switchdev_port_attr_set() to use either the blocking
> (process) or non-blocking (atomic) notifier since we typically need to
> deal with both depending on where in the bridge code we get called from.
>
> This was tested with the forwarding selftests and DSA hardware.
>
> Ido, hopefully this captures your comments done on v1, if not, can you
> illustrate with some pseudo-code what you had in mind if that's okay?
>
> Changes in v3:
>
> - added Reviewed-by tags from Ido where relevant
> - added missing notifier_to_errno() in net/bridge/br_switchdev.c when
> calling the atomic notifier for PRE_BRIDGE_FLAGS
> - kept mlxsw_sp_switchdev_init() in mlxsw/
>
> Changes in v2:
>
> - do not check for SWITCHDEV_F_DEFER when calling the blocking notifier
> and instead directly call the atomic notifier from the single location
> where this is required
Series applied, thanks Florian.
I'll push this out after my build tests complete.
prev parent reply other threads:[~2019-02-27 20:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 19:44 Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 2/8] rocker: Handle SWITCHDEV_PORT_ATTR_SET Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 3/8] net: dsa: " Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 4/8] mlxsw: spectrum_switchdev: " Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 5/8] net: mscc: ocelot: " Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 6/8] staging: fsl-dpaa2: ethsw: " Florian Fainelli
2019-02-27 19:44 ` [PATCH net-next v3 7/8] net: switchdev: Replace port attr set SDO with a notification Florian Fainelli
2019-02-27 20:16 ` Ido Schimmel
2019-02-27 19:44 ` [PATCH net-next v3 8/8] net: Remove switchdev_ops Florian Fainelli
2019-02-27 20:16 ` Ido Schimmel
2019-02-27 20:18 ` [PATCH net-next v3 0/8] " Ido Schimmel
2019-02-27 20:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227.124019.281722845670775310.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®