From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7CCC43381 for ; Thu, 28 Feb 2019 09:14:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8A20218AE for ; Thu, 28 Feb 2019 09:14:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732039AbfB1JOh (ORCPT ); Thu, 28 Feb 2019 04:14:37 -0500 Received: from foss.arm.com ([217.140.101.70]:44690 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731450AbfB1JOh (ORCPT ); Thu, 28 Feb 2019 04:14:37 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E2098EBD; Thu, 28 Feb 2019 01:14:36 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8B0FE3F738; Thu, 28 Feb 2019 01:14:35 -0800 (PST) Date: Thu, 28 Feb 2019 09:14:29 +0000 From: Mark Rutland To: Dmitry Vyukov Cc: LKML , Alexander Potapenko , Andrey Ryabinin , Ingo Molnar , kasan-dev , Arnd Bergmann Subject: Re: [PATCH] kasan: prevent recursive instrumentation Message-ID: <20190228091428.GA31464@lakrids.cambridge.arm.com> References: <20190222182851.21174-1-mark.rutland@arm.com> <20190225113509.GE26236@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 25, 2019 at 01:01:08PM +0100, Dmitry Vyukov wrote: > On Mon, Feb 25, 2019 at 12:35 PM Mark Rutland wrote: > > > > On Sat, Feb 23, 2019 at 11:29:45AM +0100, Dmitry Vyukov wrote: > > > On Fri, Feb 22, 2019 at 7:29 PM Mark Rutland wrote: > > > > > > > > When CONFIG_KASAN is selected, defines the > > > > prototypes for kasan_check_{read,write}(), rather than inline stubs. > > > > > > +kasan-dev@googlegroups.com > > > > > > Doesn't this do the same as? > > > https://groups.google.com/d/msg/kasan-dev/NwEdpGgUeac/oXUIRUC6CAAJ > > > > I had missed that patch -- thanks for the pointer! > > > > Either patch should both fix the issue with the EFI stub, but the > > __kasan_check*() renaming in this patch also prevents unexpected > > instrumentation within mm/kasan/common.c, if a call to kasan_check_*() > > were inlined there. > > > > If you think that robustness is worthwhile, I can spin a v2 making that > > a bit clearer, and fix the logic to look at __SANITIZE_ADDRESS__ rather > > than adding the KASAN_NOSANITIZE definition. > > > > AFAICT Arnd's patch isn't queued anywhere just yet. > > I dunno. I don't have strong preference. > Also not sure if Arnd's patch is not, say, in mm... problems of > extremely long patch submission times... patches should take at most > days to commit. I see Arnd's patch is in linux-next today, so it looks like that's solved. I'll drop this patch unless we see any other problems. Thanks, Mark.