From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1A5C43381 for ; Thu, 28 Feb 2019 15:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC79C20C01 for ; Thu, 28 Feb 2019 15:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551367315; bh=zp3GEOvVFFahC3leHyPzjJgdI5tl4y6B0KJuXpmzce4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nn/jlqBqP20mwe0RJeSpPOtIZz3HMbD6qXwEire1hKaxRbxMo1SFsMOEJfu+LPD8u Ftzt3NIGEubG0E/QSBa1g02DLDT+1O80OLmXTklMtZ3BzQFBjmwPNEe+G0MK67ULHP 1N/GbbGJ2v9RwgwiUlLr4uTXQToioKhS59SPumbw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733115AbfB1PVx (ORCPT ); Thu, 28 Feb 2019 10:21:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:47984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388526AbfB1PNr (ORCPT ); Thu, 28 Feb 2019 10:13:47 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C33F1218EA; Thu, 28 Feb 2019 15:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551366827; bh=zp3GEOvVFFahC3leHyPzjJgdI5tl4y6B0KJuXpmzce4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ziIv6TC6jKCySmbZDZ8YTYLyif+RO4QdREjYxFFHTOJnM3bo2sQ5jRe9l4R+evNaE Oq50SxwAKRQOzS0xt50xIIUbOWDOKkq47QQpweRgIqk4c2QN9Y+ibuGAYP9IVICTXz MaqS9twv4/MC2qSmGeju9U7TBlV77yWBt/c22cmE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peng Hao , Robert Jarzmik , Sasha Levin Subject: [PATCH AUTOSEL 4.14 05/36] ARM: pxa: ssp: unneeded to free devm_ allocated data Date: Thu, 28 Feb 2019 10:13:06 -0500 Message-Id: <20190228151337.12176-5-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190228151337.12176-1-sashal@kernel.org> References: <20190228151337.12176-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Hao [ Upstream commit ba16adeb346387eb2d1ada69003588be96f098fa ] devm_ allocated data will be automatically freed. The free of devm_ allocated data is invalid. Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") Signed-off-by: Peng Hao [title's prefix changed] Signed-off-by: Robert Jarzmik Signed-off-by: Sasha Levin --- arch/arm/plat-pxa/ssp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index ba13f793fbce4..b92673efffffb 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -237,8 +237,6 @@ static int pxa_ssp_remove(struct platform_device *pdev) if (ssp == NULL) return -ENODEV; - iounmap(ssp->mmio_base); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); release_mem_region(res->start, resource_size(res)); @@ -248,7 +246,6 @@ static int pxa_ssp_remove(struct platform_device *pdev) list_del(&ssp->node); mutex_unlock(&ssp_lock); - kfree(ssp); return 0; } -- 2.19.1